Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big numbers means big responsibilities #2044

Closed
sabau opened this issue Feb 21, 2019 · 9 comments · Fixed by #2105
Closed

Big numbers means big responsibilities #2044

sabau opened this issue Feb 21, 2019 · 9 comments · Fixed by #2105
Assignees
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed design-work-needed 🎨 issues that require design work before development

Comments

@sabau
Copy link
Contributor

sabau commented Feb 21, 2019

Describe the bug
Big numbers are not displayed nicely on the header with a 15" screen

To Reproduce
Steps to reproduce the behavior:

  1. Login when you are rich AF
  2. Look at your money and dislike the way they are printed, they make you look poorer

Expected behavior
See 19M or some other cool expandable shorthand that on hover or on click show the whole number

Screenshots
screenshot 2019-02-21 at 11 32 43

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome
  • Version 72

We have to decide if the fix I suggest make sense for everyone and/or what else we can do to show massive numbers, the chain will grow so also block numbers will hit big numbers

@sabau sabau added bug 🐛 issues related to unhandled errors in the code that need to be fixed discuss design-work-needed 🎨 issues that require design work before development labels Feb 21, 2019
@jbibla
Copy link
Collaborator

jbibla commented Feb 21, 2019

the SDK is going to send us Atoms, not uAtoms in the future... so this will be resolved when that is completed.

@fedekunze
Copy link
Contributor

Lol this description is golden

@jbibla
Copy link
Collaborator

jbibla commented Feb 22, 2019

still @sabau is correct - we may have some millionaire-atom-hodlers who this will be ugly for.

@jbibla jbibla self-assigned this Feb 22, 2019
@faboweb
Copy link
Collaborator

faboweb commented Feb 22, 2019

Other UIs just shorten the numbers at some point: 1000000 becomes 1m

@jbibla
Copy link
Collaborator

jbibla commented Feb 23, 2019

ah true!

1k, 1M, 1B

@jbibla
Copy link
Collaborator

jbibla commented Feb 23, 2019

still, we agreed to do the math until the REST API returns Atoms instead of uAtoms

@faboweb
Copy link
Collaborator

faboweb commented Feb 25, 2019

Let'S make big numbers font size smaller

@jbibla
Copy link
Collaborator

jbibla commented Feb 25, 2019

  • add a class if long numbers
  • do calculation for uAtoms

@faboweb faboweb removed the discuss label Feb 25, 2019
@jbibla jbibla self-assigned this Feb 25, 2019
@faboweb faboweb mentioned this issue Feb 26, 2019
5 tasks
@jbibla jbibla changed the title Big numbers means big responsabilities Big numbers means big responsibilities Feb 26, 2019
@jbibla
Copy link
Collaborator

jbibla commented Feb 26, 2019

i'd like to leave the font size as is for now - if this is an issue in the future we can add more dynamic font sizes. is that ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed design-work-needed 🎨 issues that require design work before development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants