Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update jsonschema pin #2253

Closed
wants to merge 1 commit into from
Closed

fix: update jsonschema pin #2253

wants to merge 1 commit into from

Conversation

ksbrar
Copy link
Collaborator

@ksbrar ksbrar commented Jul 11, 2022

Current failures are due to more precise error handling from this change in jsonschema: python-jsonschema/jsonschema#728

@ksbrar ksbrar requested review from connor-mccorm and tgaddair July 11, 2022 17:29
@github-actions
Copy link

github-actions bot commented Jul 11, 2022

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 32m 40s ⏱️ + 6m 8s
2 924 tests ±0  2 878 ✔️ +  5    46 💤 ±0  0  -   5 
8 772 runs  ±0  8 630 ✔️ +15  142 💤 ±0  0  - 15 

Results for commit 5157842. ± Comparison against base commit cdec598.

♻️ This comment has been updated with latest results.

@tgaddair
Copy link
Collaborator

@ksbrar is this covered by #2248, or did you want to keep it only to 4.6?

@ksbrar
Copy link
Collaborator Author

ksbrar commented Jul 11, 2022

@tgaddair it's covered, I'll close this PR (though first I would like to see if this last test actually does end up finishing)

@ksbrar ksbrar closed this Jul 11, 2022
@ksbrar ksbrar deleted the ksbrar-patch-1 branch July 11, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants