Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed splitting when providing pre-split inputs #2248

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Fixed splitting when providing pre-split inputs #2248

merged 4 commits into from
Jul 11, 2022

Conversation

tgaddair
Copy link
Collaborator

@tgaddair tgaddair commented Jul 10, 2022 •
edited
Loading

Prior behavior was not overriding the preprocessing split type to fixed when providing a pre-split dataframe. This was resulting in input dataframes being concatenated and then randomly split into a different train-test-val split.

@tgaddair tgaddair requested a review from justinxzhao July 10, 2022 15:15
@github-actions
Copy link

github-actions bot commented Jul 10, 2022 •
edited
Loading

Unit Test Results

       6 files  +    1         6 suites  +1   2h 19m 46s ⏱️ + 26m 45s
2 928 tests +    7  2 882 ✔️ +    7    46 💤 ±  0  0 ❌ ±0 
8 784 runs  +190  8 642 ✔️ +167  142 💤 +23  0 ❌ ±0 

Results for commit 710124a. ± Comparison against base commit ee1c3c9.

♻️ This comment has been updated with latest results.

@tgaddair tgaddair added v0.6 bug Something isn't working labels Jul 11, 2022
justinxzhao
justinxzhao approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tgaddair tgaddair merged commit a4eb05c into master Jul 11, 2022
@tgaddair tgaddair deleted the fix-fixed-split branch July 11, 2022 20:35
@tgaddair tgaddair mentioned this pull request Jul 11, 2022
Closed
justinxzhao pushed a commit that referenced this pull request Jul 11, 2022
@tgaddair @justinxzhao
Fixed splitting when providing pre-split inputs (#2248)
65aa566
@justinxzhao justinxzhao mentioned this pull request Jul 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinxzhao justinxzhao justinxzhao approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgaddair @justinxzhao