Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compare): allow multiple compare blocks #62

Merged
merged 11 commits into from
Jun 1, 2023
Merged

feat(compare): allow multiple compare blocks #62

merged 11 commits into from
Jun 1, 2023

Conversation

s0up4200
Copy link
Collaborator

Made it possible to set multiplecompare blocks via config.toml like this:

[[compare]]
host     = "100.100.100.100"
port     = 6776
login    = "user"
password = "password"

Copy link
Owner

@ludviglundgren ludviglundgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some further improvements:

We could change the flag for the tag duplicates, and by doing so add the option to set a custom tag.

-command.Flags().BoolVar(&tagDuplicates, "tag", false, "tag duplicates on compare")
+command.Flags().BoolVar(&tagDuplicates, "tag-duplicates", false, "tag duplicates on compare")
+command.Flags().StringVar(&overrideTag, "tag", "", "set a custom tag for duplicates on compare")

BaukeZwart added a commit to BaukeZwart/qbittorrent-cli that referenced this pull request Jun 1, 2023
@ludviglundgren ludviglundgren merged commit 91b9712 into ludviglundgren:develop Jun 1, 2023
@s0up4200 s0up4200 deleted the feat/multiple-compare-blocks branch June 1, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants