Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(methods): pause/resume/setCategory/setTag refactor #59

Merged
merged 8 commits into from
May 30, 2023
Merged

fix(methods): pause/resume/setCategory/setTag refactor #59

merged 8 commits into from
May 30, 2023

Conversation

s0up4200
Copy link
Collaborator

@s0up4200 s0up4200 commented May 25, 2023 •
edited
Loading

returns 400 in current state

the remove func is fixed in #57

s0up4200 and others added 2 commits May 25, 2023 12:54
@s0up4200
fix resume function
d748608 
returns 400 in current state
@s0up4200
fix pause as well
8bcc828
@s0up4200 s0up4200 changed the title fix(resume): resume function returning 400 fix(pause/resume): pause and resume functions returning 400 May 25, 2023
@s0up4200 s0up4200 changed the title fix(pause/resume): pause and resume functions returning 400 fix(methods): pause/resume/setCategory/setTag refactor May 30, 2023
ludviglundgren
ludviglundgren reviewed May 30, 2023
View reviewed changes
Copy link
Owner

@ludviglundgren ludviglundgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some proposed changes. Might complicate the comparisons but the config would be better.

The qbit methods changes should be done either way.

.qbt.toml.example Outdated Show resolved Hide resolved
internal/domain/config.go Outdated Show resolved Hide resolved
internal/domain/config.go Outdated Show resolved Hide resolved
@s0up4200
Copy link
Collaborator Author

Moved the compare changes into a separate PR: #62

@ludviglundgren ludviglundgren merged commit a81fc2b into ludviglundgren:develop May 30, 2023
@s0up4200 s0up4200 deleted the fix/resume-function branch May 30, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludviglundgren ludviglundgren ludviglundgren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s0up4200 @ludviglundgren