Release connections correctly #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the original check was the opposite (if connection has no open transactions) and I forgot to negate when I switched to this method
matthewmcgarvey
commented
Jan 25, 2022
| @@ -66,6 +66,11 @@ describe "Avram::SaveOperation" do | |||
| operation.saved?.should be_true | |||
| end | |||
| end | |||
|
|
|||
| it "releases connection after operation finishes and no transactions open", tags: Avram::SpecHelper::TRUNCATE do | |||
There was a problem hiding this comment.
Have to truncate instead of wrap the specs in a transaction so that there will not be any open transactions left on the connection when the operation finishes.
grepsedawk
approved these changes
Jan 25, 2022
jwoertink
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #799
I think the original check was the opposite (if connection has no open transactions) and I forgot to negate when I switched to this method. The specs didn't catch it because almost all specs run within a transaction so they just so happened to always fall into this block 🤦.