Release connection correctly when no open transactions (#800)

luckyframework · Jan 25, 2022 · 519213e · 519213e
1 parent ac281f4
commit 519213e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/spec/avram/transaction_spec.cr b/spec/avram/transaction_spec.cr
@@ -66,6 +66,11 @@ describe "Avram::SaveOperation" do
         operation.saved?.should be_true
       end
     end
+
+    it "releases connection after operation finishes and no transactions open", tags: Avram::SpecHelper::TRUNCATE do
+      PostTransactionSaveOperation.create!(title: "New Title", rollback_after_save: false)
+      TestDatabase.connections.should be_empty
+    end
   end
 
   describe "raising an error" do

diff --git a/src/avram/database.cr b/src/avram/database.cr
@@ -221,8 +221,7 @@ abstract class Avram::Database
   rescue e : Avram::Rollback
     false
   ensure
-    # TODO: not sure of this
-    if current_connection._avram_in_transaction?
+    if !current_connection._avram_in_transaction?
       current_connection.release
       connections.delete(object_id)
     end