Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick to earlgrey_es_sival: [topgen] Add field to specify status IRQ default behavior #22530

Merged
merged 1 commit into from
May 24, 2024

Conversation

nbdd0121
Copy link
Contributor

Cherry-picks a single commit in #21226 which seems to fix the rv_plic sival tests on silicon.

@nbdd0121 nbdd0121 requested review from a team and msfschaffner as code owners April 11, 2024 16:26
@nbdd0121 nbdd0121 requested review from marnovandermaas, jadephilipoom and jwnrt and removed request for a team April 11, 2024 16:26
This allows to specify whether a status type interrupt is expected to
assert by default. The field is intended to be used in generated DV
collateral, primarily.

Signed-off-by: Michael Schaffner <[email protected]>
Copy link
Contributor

@pamaury pamaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks ok. I don't know quite enough to be sure but I assume that the change to top_earlgrey.gen.hjson is just a "documentation" change, ie it doesn't actually change any RTL file?

@engdoreis
Copy link
Contributor

The commit matches the original PR.

@engdoreis engdoreis merged commit 1ead801 into lowRISC:earlgrey_es_sival May 24, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants