Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sival,pwrmgr] Rework sleep_all_reset_reqs tests #20153

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

matutem
Copy link
Contributor

@matutem matutem commented Oct 21, 2023

This has two commits. The first creates separate sleep_por tests.
The second reworks the three sleep_all_reset_reqs tests to be sequenced by the CPU,
share more code, and increase readability.

@matutem matutem requested review from a team as code owners October 21, 2023 00:48
@matutem matutem requested review from eshapira, jon-flatley and jdonjdon and removed request for a team, eshapira and jon-flatley October 21, 2023 00:48
Copy link
Contributor

@jdonjdon jdonjdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I leave a few nits.

Create chip_sw_pwrmgr_sleep_por_reset.
Create chip_sw_pwrmgr_deep_sleep_por_reset.
These tests were part of the *sleep_all_reset_reqs tests, but are moved
to their own test to simplify these tests.
They only run in sim_dv in this commit, but the rust side is in development.

Addresses lowRISC#20133
Addresses lowRISC#20134

Signed-off-by: Guillermo Maturana <[email protected]>
Create a library to share the C code.
Remove some redundant test cases.
Avoid memory overwrite, instead have the CPU sequence the reset cases.
Adjust SV sequence so it can deal with all three tests.

Addresses lowRISC#20133
Addresses lowRISC#20134

Signed-off-by: Guillermo Maturana <[email protected]>
@matutem matutem merged commit 2380df3 into lowRISC:master Oct 23, 2023
5 of 12 checks passed
@matutem matutem deleted the pwrmgr_all_resets branch October 23, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants