[bazel] Add capability to execute jtag/RAM tests #19719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfrantz
force-pushed
the
bazel-ram
branch
3 times, most recently
from
5cbf34b
to
986d4f5
Compare
pamaury
approved these changes
Oct 2, 2023
cfrantz
force-pushed
the
bazel-ram
branch
5 times, most recently
from
2ad9318
to
ed1ede8
Compare
1. Add a `kind` attribute to the binary and test rules to indicate
whether the target is for flash, ram or rom.
2. Plumb flash scrambling support into the exec_env and binary rules.
3. Update the `rom` attribute in the exec environments and binary rules.
Allow the label to be any provider.
4. Implement flash and rom paths for fpga_cw310 and sim_{dv,verilator}.
4a. When building, apply the scrambling transform to the ROM binary.
4b. When testing, retrieve the supplied ROM and substitute it into the
test flow. Currently, only verilator can run ROM tests.
5. Update `sim.mk` to collect the correct file resources for the
test_rom.
Signed-off-by: Chris Frantz <[email protected]>
1. Re-arrange the exec_envs so that there are environments that do not depend on the ROM targets. 2. Convert the test_rom target to use `opentitan_binary`. 3. Update the `test_rom_test` to use the standard exec_envs. 4. Add tentative CW340 support (build only - testing not yet supported). Signed-off-by: Chris Frantz <[email protected]>
Demonstrate how to convert a `test_in_rom` test to the new opentitan_test rule. Signed-off-by: Chris Frantz <[email protected]>
1. Define a basic CW305 exec_env.The build/release pipeline expects to find cw305 artifacts for the test_rom. 2. The englishbreakfast verilator model does not understand ROM scrambling, so we also create a non-scrambled VMEM file. Signed-off-by: Chris Frantz <[email protected]>
1. RAM-based binaries need only produce the `.elf` file. 2. Create a `cw310_jtag_params` helper that includes the necessary dependencies and flags for a JTAG test dispatch via opentitantool. Signed-off-by: Chris Frantz <[email protected]>
Signed-off-by: Chris Frantz <[email protected]>
cfrantz
requested review from
moidx
and removed request for
a team and
rswarbrick
This was referenced Oct 6, 2023
This was referenced Oct 6, 2023
timothytrippel
approved these changes
Oct 6, 2023
I guess we can eventually remove the option to load SRAM VMEM programs then: https://cs.opensource.google/opentitan/opentitan/+/master:sw/host/opentitanlib/src/test_utils/load_sram_program.rs;drc=05ba6772e04509a9ed133e692cda16d6dc9cd309;l=36 |
moidx
approved these changes
Oct 6, 2023
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.elffile.cw310_jtag_paramshelper that includes the necessarydependencies and flags for a JTAG test dispatch via opentitantool.
Note: this PR depends on #19650, #19697 and #19710. You need only review the last two commits.