[bazel] Update the binary/test rules for building ROMs #19710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfrantz
force-pushed
the
bazel-rom
branch
3 times, most recently
from
886c49d
to
abd01bd
Compare
pamaury
reviewed
Sep 26, 2023
pamaury
reviewed
Oct 2, 2023
| @@ -113,6 +138,12 @@ def _test_dispatch(ctx, exec_env, provider): | |||
|
|
|||
| # Get the pre-test_cmd args. | |||
| args = get_fallback(ctx, "attr.args", exec_env) | |||
| if ctx.attr.kind == "rom": | |||
| # FIXME: This is a bit of inside-baseball: We know the opentitantool | |||
There was a problem hiding this comment.
This might be more complicated but maybe the param dict should have two test commands, one for flash-based tests and one for rom-based tests? Say, if args is an array, it is valid for all kind, but it can also be a dictionary of key/values where the keys are the kind.
There was a problem hiding this comment.
I have two alternate ideas to explore rather than making the test_env more complex:
- Allow opentitantool to accept an empty parameter for
--verilator-flash, meaning there is no flash payload. This is the current behavior with--verilator-{rom,otp}and used to be the behavior withflash. It changed when opentitantool was updated to accept multiple flash args to load multiple banks. - Provide an "empty" VMEM file to load into flash.
cfrantz
force-pushed
the
bazel-rom
branch
5 times, most recently
from
ba0a8ad
to
f090160
Compare
1. Add a `kind` attribute to the binary and test rules to indicate
whether the target is for flash, ram or rom.
2. Plumb flash scrambling support into the exec_env and binary rules.
3. Update the `rom` attribute in the exec environments and binary rules.
Allow the label to be any provider.
4. Implement flash and rom paths for fpga_cw310 and sim_{dv,verilator}.
4a. When building, apply the scrambling transform to the ROM binary.
4b. When testing, retrieve the supplied ROM and substitute it into the
test flow. Currently, only verilator can run ROM tests.
5. Update `sim.mk` to collect the correct file resources for the
test_rom.
Signed-off-by: Chris Frantz <[email protected]>
1. Re-arrange the exec_envs so that there are environments that do not depend on the ROM targets. 2. Convert the test_rom target to use `opentitan_binary`. 3. Update the `test_rom_test` to use the standard exec_envs. 4. Add tentative CW340 support (build only - testing not yet supported). Signed-off-by: Chris Frantz <[email protected]>
Demonstrate how to convert a `test_in_rom` test to the new opentitan_test rule. Signed-off-by: Chris Frantz <[email protected]>
1. Define a basic CW305 exec_env.The build/release pipeline expects to find cw305 artifacts for the test_rom. 2. The englishbreakfast verilator model does not understand ROM scrambling, so we also create a non-scrambled VMEM file. Signed-off-by: Chris Frantz <[email protected]>
cfrantz
requested review from
moidx
and removed request for
a team and
rswarbrick
timothytrippel
approved these changes
Oct 6, 2023
|
The commits in this PR were merged as part of #19719. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kindattribute to the binary and test rules to indicatewhether the target is for flash, ram or rom.
romattribute in the exec environments and binary rules.Allow the label to be any provider.
4a. When building, apply the scrambling transform to the ROM binary.
4b. When testing, retrieve the supplied ROM and substitute it into the
test flow. Currently, only verilator can run ROM tests.
test_romwith the new rules.rom_epmp_testto the new rules.This PR depends on #19650 and #19697. You need only review the last 3 commits.