-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bazel] Allocate CW310s based on extra resources #16436
base: master
Are you sure you want to change the base?
Conversation
Tested with a
Note verilator is building and FPGA tests are running |
Addressed comments on bazelbuild#13996 Fixed issues in tests and built and tested with lowRISC/opentitan#16436 Signed-off-by: Drew Macrae <[email protected]>
Using the "cpu:" tag to control verilator makes it harder to control the number of threads verilator tests are allocated at the command line. The machinery to build verilator for n threads is still in place, we can still build for 4 by default and tag verilator tests with "cpu:4", but bazelbuild/bazel#16786 keeps us from limiting the total number of tests HOST_CPUs/verilator_threads when we change the number of threads verilator is built for. It's a hack but I'm using:
|
there are some rstmgr and alert_handler tests that are a bit flaky when tests aren't exclusive. I think there are some race conditions. I've seen some failures in: |
Addressed comments on bazelbuild#13996 Fixed issues in tests and built and tested with lowRISC/opentitan#16436 Signed-off-by: Drew Macrae <[email protected]>
11b6f2a
to
b8f044e
Compare
Decreases our test suite from 345m down to 188m, but running tests in parallel means we can catch new errors orders of magnitude faster. |
Addressed comments on bazelbuild#13996 Fixed issues in tests and built and tested with lowRISC/opentitan#16436 Signed-off-by: Drew Macrae <[email protected]>
Addressed comments on bazelbuild#13996 Fixed issues in tests and built and tested with lowRISC/opentitan#16436 Signed-off-by: Drew Macrae <[email protected]>
Addressed comments on bazelbuild#13996 Fixed issues in tests and built and tested with lowRISC/opentitan#16436 Signed-off-by: Drew Macrae <[email protected]>
Addressed comments on bazelbuild#13996 Fixed issues in tests and built and tested with lowRISC/opentitan#16436 Signed-off-by: Drew Macrae <[email protected]>
Addressed comments on bazelbuild#13996 Fixed issues in tests and built and tested with lowRISC/opentitan#16436 Signed-off-by: Drew Macrae <[email protected]>
b8f044e
to
ec1653c
Compare
ec1653c
to
4fec2ff
Compare
WIP requires custom bazel binary. Don't merge until bazel is updated to reflect upstream changes. Removes the external tag in preference for a custom resource as handled by bazelbuild/bazel#16785 Signed-off-by: Drew Macrae <[email protected]>
4fec2ff
to
a2232f3
Compare
profile2.gz |
This recreates a [closed PR](#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436 Fixes:#16817 Closes #16785. PiperOrigin-RevId: 498557024 Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68
This recreates a [closed PR](bazelbuild#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436 Fixes:bazelbuild#16817 Closes bazelbuild#16785. PiperOrigin-RevId: 498557024 Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68
This recreates a [closed PR](#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436 Fixes:#16817 Closes #16785. PiperOrigin-RevId: 498557024 Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68 Co-authored-by: kshyanashree <[email protected]>
This recreates a [closed PR](#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436 Fixes:#16817 Closes #16785. PiperOrigin-RevId: 498557024 Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68
WIP requires custom bazel binary. Add's the extra resource "cw310" so that 1 test can be dispatched concurrently to other testing.
Signed-off-by: Drew Macrae [email protected]