[bazel] Remove broken tag from passing tests

Signed-off-by: Drew Macrae <[email protected]>
lowRISC · Nov 23, 2022 · 11b6f2a · 11b6f2a
1 parent 72a7ba9
commit 11b6f2a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 28 deletions.
diff --git a/rules/opentitan_gdb_test.bzl b/rules/opentitan_gdb_test.bzl
@@ -237,7 +237,7 @@ def opentitan_gdb_fpga_cw310_test(
     _opentitan_gdb_fpga_cw310_test(
         tags = tags + [
             "cw310",
-            "exclusive",  # Prevent FPGA tests from running concurrently.
+            "resource:cw310:1",  # Prevent FPGA tests from running concurrently.
             "jtag",
         ],
         opentitantool_cw310_uarts = select({

diff --git a/sw/device/tests/BUILD b/sw/device/tests/BUILD
@@ -44,10 +44,6 @@ opentitan_functest(
 opentitan_functest(
     name = "aes_entropy_test",
     srcs = ["aes_entropy_test.c"],
-    cw310 = cw310_params(
-        # FIXME #12486 [bazel] targets in sw/device/tests failing on cw310 and verilator when built by bazel
-        tags = ["broken"],
-    ),
     deps = [
         "//hw/ip/aes:model",
         "//hw/top_earlgrey/sw/autogen:top_earlgrey",
@@ -84,10 +80,6 @@ opentitan_functest(
 opentitan_functest(
     name = "aes_idle_test",
     srcs = ["aes_idle_test.c"],
-    cw310 = cw310_params(
-        # FIXME #12486 [bazel] targets in sw/device/tests failing on cw310 and verilator when built by bazel
-        tags = ["broken"],
-    ),
     deps = [
         "//hw/ip/aes:model",
         "//hw/top_earlgrey/sw/autogen:top_earlgrey",
@@ -578,10 +570,6 @@ opentitan_functest(
 opentitan_functest(
     name = "clkmgr_reset_frequency_test",
     srcs = ["clkmgr_reset_frequency_test.c"],
-    cw310 = cw310_params(
-        # FIXME #13611
-        tags = ["broken"],
-    ),
     verilator = verilator_params(
         # FIXME #13611
         tags = ["broken"],
@@ -604,10 +592,6 @@ opentitan_functest(
 opentitan_functest(
     name = "clkmgr_sleep_frequency_test",
     srcs = ["clkmgr_sleep_frequency_test.c"],
-    cw310 = cw310_params(
-        # FIXME #13611
-        tags = ["broken"],
-    ),
     verilator = verilator_params(
         # FIXME #13611
         tags = ["broken"],
@@ -1417,10 +1401,11 @@ opentitan_functest(
 opentitan_functest(
     name = "rstmgr_cpu_info_test",
     srcs = ["rstmgr_cpu_info_test.c"],
-    cw310 = cw310_params(
-        # FIXME #12486 [bazel] targets in sw/device/tests failing on cw310 and verilator when built by bazel
-        tags = ["broken"],
-    ),
+    targets = [
+        "cw310_test_rom",
+        "dv",
+        "verilator",
+    ],
     verilator = verilator_params(
         timeout = "long",
         tags = ["broken"],

diff --git a/sw/device/tests/crypto/BUILD b/sw/device/tests/crypto/BUILD
@@ -11,15 +11,8 @@ package(default_visibility = ["//visibility:public"])
 opentitan_functest(
     name = "aes_gcm_functest",
     srcs = ["aes_gcm_functest.c"],
-    cw310 = cw310_params(
-        timeout = "long",
-        tags = ["broken"],  # https://github.com/lowRISC/opentitan/issues/15788
-        # [test-triage] test not constant time with icache enabled
-    ),
     verilator = verilator_params(
         timeout = "long",
-        tags = ["broken"],  # https://github.com/lowRISC/opentitan/issues/15788
-        # [test-triage] test not constant time with icache enabled
     ),
     deps = [
         ":aes_gcm_testutils",
@@ -53,9 +46,13 @@ opentitan_functest(
     srcs = ["aes_gcm_timing_test.c"],
     cw310 = cw310_params(
         timeout = "long",
+        tags = ["broken"],  # https://github.com/lowRISC/opentitan/issues/15788
+        # [test-triage] test not constant time with icache enabled
     ),
     verilator = verilator_params(
         timeout = "long",
+        tags = ["broken"],  # https://github.com/lowRISC/opentitan/issues/15788
+        # [test-triage] test not constant time with icache enabled
     ),
     deps = [
         ":aes_gcm_testutils",