[topgen] Remove duplicated license headers from autogen files

[vogelpi]

A couple of our auto-generated files have duplicated license headers. One copy is inserted by util/topgen.py and the other copy comes in via template file. In addition some auto-generated files do not contain the warning that they are auto-generated.

We should probably:

1. Make sure all our templates have a license banner that does not get into the autogen file.
2. Change topgen to only insert the license banner together with a warning that this is auto-generated to all auto-generated files.

Currently, the following files have a duplicated banner:

grep -Rc --include \*.sv SPDX- * | grep ":2"
hw/top_earlgrey/ip/clkmgr/rtl/autogen/clkmgr.sv:2                                                                                                                                                                                    
hw/top_earlgrey/ip/clkmgr/rtl/autogen/clkmgr_pkg.sv:2                                                                                                                                                                                       
hw/top_earlgrey/ip/flash_ctrl/rtl/autogen/flash_ctrl.sv:2                                                                                                                                                                                   
hw/top_earlgrey/ip/flash_ctrl/rtl/autogen/flash_ctrl_region_cfg.sv:2                                                                                                                                                                        
hw/top_earlgrey/ip/flash_ctrl/rtl/autogen/flash_ctrl_pkg.sv:2

[tjaychen]

ooops! this is my bad.
I think it's probably a result of the ip level example not having that header (thus included in the template), and topgen.py having it.
I'll fix the clkmgr ones.

[vogelpi]

Hi @tjaychen,
no worries. I wanted to look into this at some point but will have to do some other stuff first. I also noted that some autogen files have a line saying something like "this file has been generated with the following command" and then there is no command. I thought to solve both these things in one shot.

[msfschaffner]

@vogelpi is this still pending or can we close this?

[vogelpi]

Yes, it's still an issue. For current master I got:

grep -Rc --include \*.sv SPDX- * | grep ":2"
hw/top_earlgrey/ip/flash_ctrl/rtl/autogen/flash_ctrl_region_cfg.sv:2
hw/top_earlgrey/ip/flash_ctrl/rtl/autogen/flash_ctrl.sv:2
hw/top_earlgrey/ip/flash_ctrl/rtl/autogen/flash_ctrl_pkg.sv:2
hw/top_earlgrey/ip/clkmgr/rtl/autogen/clkmgr_pkg.sv:2
hw/top_earlgrey/ip/clkmgr/rtl/autogen/clkmgr.sv:2
hw/top_earlgrey/ip/rstmgr/rtl/autogen/rstmgr_pkg.sv:2
hw/top_earlgrey/ip/rstmgr/rtl/autogen/rstmgr.sv:2
hw/top_earlgrey/ip/rstmgr/dv/sva/autogen/rstmgr_rst_en_track_sva_if.sv:2

However, this is really ultra-low priority. And I believe it would still be a good starter task.

[matutem]

These duplicate license headers don't get generated by the ipgen flow, so they will be gone once #8440 is complete. As it stands the ones in rstmgr are already gone.