Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

lowRISC / opentitan Public

Notifications You must be signed in to change notification settings
Fork 779
Star 2.6k

Code
Issues 1.3k
Pull requests 343
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tracking] Use ipgen to produce templated IPs #8440

Closed

17 tasks done

imphil opened this issue Sep 29, 2021 · 13 comments

Closed

17 tasks done

[tracking] Use ipgen to produce templated IPs #8440

imphil opened this issue Sep 29, 2021 · 13 comments

Assignees

Labels

Component:Tooling

Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR

Earlgrey-PROD Candidate

Temporary label to triage issues into Earlgrey-PROD Milestones

IP:clkmgr IP:flash_ctrl IP:otp_ctrl IP:pwrmgr IP:rstmgr Priority:P2

Priority: medium

Triaging:MultipleBlocks

Issue is relevant for the triage of multiple HW blocks

Cleanup tasks

Milestone

Comments

Copy link

Contributor

imphil commented Sep 29, 2021 •

edited by matutem

Loading

The following IP blocks are actually templates at the moment and need to be converted to be using ipgen (slides discussing motivation and general approach).

alert_handler: [alert_handler] Produce top_earlgrey instance of alert_handler with ipgen #8513
clkmgr
- Create ipgen files: [ipgen,clkmgr] Create ipgen files #21202
- Transition to ipgen files and remove old files: [Ipgen,clkmgr] Change clkmgr to ipgen #21321
flash_ctrl
- Create ipgen files: [ipgen,flash_ctrl] Create ipgen files #21170
- Transition to ipgen files and remove old files: [ipgen,flash_ctrl] Generate flash_ctrl with ipgen #22518
pinmux: Ipgen pinmux #24808
pwrmgr: [pwrmgr,ipgen] Convert pwrmgr to ipgen #19801
rstmgr: [ipgen,rstmgr] Generate rstmgr with ipgen #21041
rv_plic: Use ipgen to generate rv_plic #8431

When the list above is done

Remove topgen support for "templated" module "attr" attribute: [util,topgen] Remove support for templated ips #25129
Remove topgen quirks due to templated path searches, as for countermeasures: [util,topgen] Remove support for templated ips #25129

Blocks which were unclear, and their resolution:

ast: doesn't need generation
xbar: xbars have their own dedicated generation
xbar_main: xbars have their own dedicated generation
xbar_peri: xbars have their own dedicated generation

The text was updated successfully, but these errors were encountered:

All reactions

imphil added the Type:Enhancement Feature requests, enhancements label

imphil self-assigned this

msfschaffner added Component:Tooling

Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR

Priority:P2 Priority: medium labels

msfschaffner added this to the Project: M2 milestone

msfschaffner assigned tjaychen, eunchan and msfschaffner

msfschaffner added Type:Cleanup Cleanup tasks and removed Type:Enhancement Feature requests, enhancements labels

msfschaffner assigned rswarbrick, GregAC and vogelpi

msfschaffner mentioned this issue

[otp_ctrl] D3 opens #13438

Closed

9 tasks

msfschaffner modified the milestones: Project: M2, Project: M3

msfschaffner unassigned imphil

tjaychen mentioned this issue

[rtl] Eliminate sources with autogen file #6519

Closed

msfschaffner mentioned this issue

[rom-e2e] e2e_weak_straps tests #15990

Merged

Copy link

Contributor

msfschaffner commented Nov 18, 2022

All reactions

Sorry, something went wrong.

tjaychen assigned jeoongp

GregAC added the Triaging:MultipleBlocks Issue is relevant for the triage of multiple HW blocks label

GregAC modified the milestones: Discrete: M3, Backlog

GregAC added the Type:FutureRelease Not relevant to currently planned releases/milestones label

Copy link

Contributor

GregAC commented Feb 22, 2023

Triaging for flash_ctrl. This is a significant chunk of work and not required for M2.5, however it is likely useful for integrated.

All reactions

Sorry, something went wrong.

GregAC added the IP:flash_ctrl label

Copy link

Contributor

andreaskurth commented Feb 22, 2023

Triaged for pwrmgr - agree

All reactions

Sorry, something went wrong.

andreaskurth added IP:clkmgr IP:pwrmgr labels

andrea-caforio pushed a commit to andrea-caforio/opentitan that referenced this issue


          [ipgen,pinmux] Generate pinmux files with ipgen

b99a222

The older way to generate files is preserved.

Part of pinmux lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

andrea-caforio pushed a commit to andrea-caforio/opentitan that referenced this issue


          [ipgen,pinmux] Fix md files

44717a3

Changes paths to pinmux to new ip_autogen files or to non-template
files in ip_templates when linked from directories in plain hw/ip.

Run cmdgen.py to populate contents of pinmux autogen registers and
interfaces md files.

Part of pinmux lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

andrea-caforio pushed a commit to andrea-caforio/opentitan that referenced this issue


          [ipgen,pinmux] Fix BUILD files

fe2375d

Part of pinmux lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

andrea-caforio pushed a commit to andrea-caforio/opentitan that referenced this issue


          [ipgen,pinmux] Fix hjson files

9250eb3

Also change the flash_ctrl attr to ipgen.
Change top_earlgrey_fpv_ip_cfgs.hjson to run both pinmux tbs,
adjust paths, and fusesoc targets.

Part of pinmux lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

andrea-caforio pushed a commit to andrea-caforio/opentitan that referenced this issue


          [ipgen,pinmux] Fix link in non-generated dif header

7d4d1db

Part of pinmux lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

andrea-caforio pushed a commit to andrea-caforio/opentitan that referenced this issue


          [ipgen,pinmux] Fix paths in verible allowlist

133dee5

Part of pinmux lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

andrea-caforio pushed a commit to andrea-caforio/opentitan that referenced this issue


          [ipgen,pinmux] Fix documentation collateral

f04a35d

Part of pinmux lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

andrea-caforio pushed a commit to andrea-caforio/opentitan that referenced this issue


          [ipgen,pinmux] Fix external core files

3e2f333

This fixes core files outside pinmux to use the correct dependencies.

Part of pinmux lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

andrea-caforio pushed a commit to andrea-caforio/opentitan that referenced this issue


          [ipgen,pinmux] Fix englishbreakfast build

ce6ced4

Part of pinmux lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

andrea-caforio pushed a commit to andrea-caforio/opentitan that referenced this issue


          [ipgen,pinmux] Change topgen to ipgen pinmux and remove old files

5c02062

This deletes all hw/ip/pinmux and hw/top_earlgrey/ip/pinmux files
since they are no longer used.

Part of pinmux lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,topgen] Remove support for templated ips

5ff5518

Check modules have no 'attr' field, or it is ipgen, reggen_top,
or reggen_only.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem mentioned this issue

[util,topgen] Remove support for templated ips #25129

Merged

matutem added a commit to matutem/opentitan that referenced this issue


          [util,ipgen] Improve docs, exception handling, and simplicity

9c217b7

Render ip description now requires an hjson.tpl file: it used to
accept a non-template one, but those have already been removed
from the repo.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,topgen] Remove support for templated ips

Check modules have no 'attr' field, or it is ipgen, reggen_top,
or reggen_only.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,ipgen] Improve docs, exception handling, and simplicity

8b91a9c

Render ip description now requires an hjson.tpl file: it used to
accept a non-template one, but those have already been removed
from the repo.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,topgen] Remove support for templated ips

0c5c50b

Check modules have no 'attr' field, or it is ipgen, reggen_top,
or reggen_only.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,ipgen] Improve docs, exception handling, and simplicity

8bae5ba

Render ip description now requires an hjson.tpl file: it used to
accept a non-template one, but those have already been removed
from the repo.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,topgen] Remove support for templated ips

fb32a87

Check modules have no 'attr' field, or it is ipgen, reggen_top,
or reggen_only.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,ipgen] Improve docs, exception handling, and simplicity

c5e046d

Render ip description now requires an hjson.tpl file: it used to
accept a non-template one, but those have already been removed
from the repo.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,topgen] Remove support for templated ips

b06b025

Check modules have no 'attr' field, or it is ipgen, reggen_top,
or reggen_only.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,ipgen] Improve docs, exception handling, and simplicity

2ff9e0b

Render ip description now requires an hjson.tpl file: it used to
accept a non-template one, but those have already been removed
from the repo.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,topgen] Remove support for templated ips

8693a05

Check modules have no 'attr' field, or it is ipgen, reggen_top,
or reggen_only.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,ipgen] Improve docs, exception handling, and simplicity

8e00fae

Render ip description now requires an hjson.tpl file: it used to
accept a non-template one, but those have already been removed
from the repo.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,topgen] Remove support for templated ips

8fe5461

Check modules have no 'attr' field, or it is ipgen, reggen_top,
or reggen_only.
Remove handling of templated ips in a few places under the util tree.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit to matutem/opentitan that referenced this issue


          [util,ipgen] Improve docs, exception handling, and simplicity

70d30d8

Render ip description now requires an hjson.tpl file: it used to
accept a non-template one, but those have already been removed
from the repo.

Part of lowRISC#8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added the IP:otp_ctrl label

matutem added a commit that referenced this issue


          [util,topgen] Remove support for templated ips

d38e204

Check modules have no 'attr' field, or it is ipgen, reggen_top,
or reggen_only.
Remove handling of templated ips in a few places under the util tree.

Part of #8440

Signed-off-by: Guillermo Maturana <[email protected]>

matutem added a commit that referenced this issue


          [util,ipgen] Improve docs, exception handling, and simplicity

dc01523

Render ip description now requires an hjson.tpl file: it used to
accept a non-template one, but those have already been removed
from the repo.

Part of #8440

Signed-off-by: Guillermo Maturana <[email protected]>

Copy link

Contributor

matutem commented Nov 19, 2024 •

edited

Loading

Closing this since the work on otp_ctrl is tracked in a separate issue: #25019

All reactions

Sorry, something went wrong.

matutem closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Assignees

Labels

Component:Tooling

Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR

Earlgrey-PROD Candidate

Temporary label to triage issues into Earlgrey-PROD Milestones

IP:clkmgr IP:flash_ctrl IP:otp_ctrl IP:pwrmgr IP:rstmgr Priority:P2

Priority: medium

Triaging:MultipleBlocks

Issue is relevant for the triage of multiple HW blocks

Cleanup tasks

Projects

None yet

Milestone

Multi-Top

Development

No branches or pull requests

13 participants

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.