Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hmac, TLT] Extend multistream top-level test for HMAC #23507

Closed
ballifatih opened this issue Jun 5, 2024 · 2 comments
Closed

[hmac, TLT] Extend multistream top-level test for HMAC #23507

ballifatih opened this issue Jun 5, 2024 · 2 comments
Assignees
@ballifatih
Labels
Component:DV DV issue: testbench, test case, etc. IP:hmac
Milestone
Earlgrey-PROD.M5

Comments

@ballifatih
Copy link
Contributor

Description

Spin-off from #23494 (review), #23494 (comment) and #23471 (comment)

Current HMAC multistream TLT is about HMAC/SHA-2 streams that perform context switches in interleaving fashion. We would like to improve this test in order to have a better coverage:

  • It would be nice to visit each test twice so that the same digest/key-size vectors also repeat each other.
  • Mix between one-shot and streaming calls. In particular, having oneshot calls between streams could be interesting.
  • Instead of dividing the input message into equal-sized two parts and making 2 update calls, consider feeding each message in [1, 4] update calls randomly.
  • Randomize the order the tests are run.

Related to #22332
@ballifatih ballifatih added Component:DV DV issue: testbench, test case, etc. IP:hmac labels Jun 5, 2024
@ballifatih ballifatih added this to the Earlgrey-PROD.M5 milestone Jun 5, 2024
@ballifatih ballifatih mentioned this issue Jun 5, 2024
Merged
@martin-velay martin-velay mentioned this issue Jun 6, 2024
Closed
ballifatih added a commit to ballifatih/opentitan that referenced this issue Jun 22, 2024
@ballifatih
[hmac, dv] Extend multistream TLT
4090879 
Related to lowRISC#23507.

Extends the multistream HMAC test so that:
* One-shot and streaming calls are mixed.
* Streaming calls are divided into random
number of message segments [1, 4].
* The order of test vectors is randomized.

Signed-off-by: Fatih Balli <[email protected]>
ballifatih added a commit to ballifatih/opentitan that referenced this issue Jun 22, 2024
@ballifatih
[hmac, dv] Extend multistream TLT
00c2f5c 
Related to lowRISC#23507.

Extends the multistream HMAC test so that:
* One-shot and streaming calls are mixed.
* Streaming calls are divided into random
number of message segments [1, 4].
* The order of test vectors is randomized.

Signed-off-by: Fatih Balli <[email protected]>
ballifatih added a commit to ballifatih/opentitan that referenced this issue Jun 22, 2024
@ballifatih
[hmac, dv] Extend multistream TLT
452cf6f 
Related to lowRISC#23507.

Extends the multistream HMAC test so that:
* One-shot and streaming calls are mixed.
* Streaming calls are divided into random
number of message segments [1, 4].
* The order of test vectors is randomized.

Signed-off-by: Fatih Balli <[email protected]>
@ballifatih ballifatih mentioned this issue Jun 22, 2024
Merged
moidx pushed a commit that referenced this issue Jun 24, 2024
@ballifatih @moidx
[hmac, dv] Extend multistream TLT
7483d26 
Related to #23507.

Extends the multistream HMAC test so that:
* One-shot and streaming calls are mixed.
* Streaming calls are divided into random
number of message segments [1, 4].
* The order of test vectors is randomized.

Signed-off-by: Fatih Balli <[email protected]>
@vogelpi
Copy link
Contributor

vogelpi commented Jul 1, 2024

@ballifatih, based on the description of PR #23780, I think all the points raised above have been taken care of and we can close this issue. Do you agree? If not, can you please clarify what's missing? Thanks!

@ballifatih
Copy link
Contributor Author

I only wanted to see few runs of the TLT before closing this. I just had a quick look at the last three runs of chip_sw_hmac_multistream and they were all passing. I am closing this issue.

AlexJones0 pushed a commit to AlexJones0/opentitan that referenced this issue Jul 8, 2024
@ballifatih @AlexJones0
[hmac, dv] Extend multistream TLT
579c5cc 
Related to lowRISC#23507.

Extends the multistream HMAC test so that:
* One-shot and streaming calls are mixed.
* Streaming calls are divided into random
number of message segments [1, 4].
* The order of test vectors is randomized.

Signed-off-by: Fatih Balli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ballifatih ballifatih

Labels
Component:DV DV issue: testbench, test case, etc. IP:hmac
Projects
None yet
Milestone
Earlgrey-PROD.M5
Development

No branches or pull requests
2 participants
@ballifatih @vogelpi