-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hmac,difs] Update DIFs and DIF-based TLTs #22332
Comments
My plan is to focus on extending DIFs and adding a top-level test for streaming. Just mentioning this here, so we do not duplicate the effort. |
At the moment, we are using TLTs implemented on top of cryptolib HMAC driver to get nightly results. It would make sense to implement these tests on top of DIFs instead of the driver, but I think that is not M4 priority. We have two relevant top-level tests, one is testing oneshot calls and the other one is testing multistream (i.e. streams that are running in parallel and interleaving each other with context switching). Relevant PRs:
I would update the milestone as M5 or later. |
Labeling this as M5 since at M4 we exercise the new features at block-level and test one-shot and streaming HMAC with KAT test vectors at the top-level using the driver-based TLTs referenced above by @ballifatih. |
In my view, if we have TLTs using these hardware features through the cryptolib, we don't need to write further TLTs for these features. Ideally, the DIF can still be extended provide those interfaces. However, both tasks don't sound like a M5 item to me. What we care about is the coverage of these features at the top level (and block level) and my understanding is that we have that coverage now already. |
So in my view we can de-prioritze this. |
From an offline discussion between @gdessouky and @martin-velay : "this will enable us to try out at top-level different scenarios with context switching" - 4 days estimated effort. |
Discussed in triage meeting to leave this in. |
Moved to M7 backlog as this is not relevant for the V3 signoff |
Description
At the moment, HMAC DIFs and drivers configure HMAC by default in SHA-2 256 and 256-bit key. To support TLTs configuring different digest sizes and key lengths, the DIFs need to be updated and the corresponding documentation. Additionally, we need to exercise reading the HMAC error code for invalid configuration.
The text was updated successfully, but these errors were encountered: