Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i2c,dv] Failing block level DV tests as a result of changes. #21755

Closed
alees24 opened this issue Feb 29, 2024 · 6 comments
Closed

[i2c,dv] Failing block level DV tests as a result of changes. #21755

alees24 opened this issue Feb 29, 2024 · 6 comments
Assignees
Labels
Component:DV DV issue: testbench, test case, etc. IP:i2c

Comments

@alees24
Copy link
Contributor

alees24 commented Feb 29, 2024

Description

This issue tracks the state of block level I2C tests, broken or made less reliable by DD work for prod.

Probably failing/unreliable already:

i2c_target_stress_all_with_rand_reset

PR #21621 at this time is thought to be responsible for breaking the following:

  • i2c_host_fifo_reset_fmt
  • i2c_host_fifo_watermark
  • i2c_target_smoke
  • i2c_target_stress_rd

Others:

@alees24 alees24 self-assigned this Feb 29, 2024
@andreaskurth andreaskurth added this to the Earlgrey-PROD.M4 milestone Mar 1, 2024
@andreaskurth andreaskurth added Component:DV DV issue: testbench, test case, etc. IP:i2c labels Mar 1, 2024
@andreaskurth
Copy link
Contributor

andreaskurth commented Mar 1, 2024

i2c_host_fifo_watermark is another victim, I think. It passes before the merge of #21621 but fails after (seed 9596103540527566890202921826073542621372745652001006134958711591620971245237 on VCS T-2022.06-SP2). I added it to the list.

@andreaskurth
Copy link
Contributor

i2c_target_stress_rd as well: it passes before the merge of #21621 but fails after (seed 1123967404029634992796962205584092120176243998109053670291080899048047786851 on VCS T-2022.06-SP2). This test simply extends i2c_target_smoke, which may explain why it fails as well.

Added to the list.

@andreaskurth andreaskurth changed the title [dv,i2c] Failing block level DV tests as a result of changes. [i2c,dv] Failing block level DV tests as a result of changes. Apr 19, 2024
@a-will
Copy link
Contributor

a-will commented May 4, 2024

These all seem to be passing now--I fixed up several of these along the way.

We're not at 100% at this point, though:

  • i2c_csr_bit_bash overflows FIFOs and triggers assertions inside the newer FIFO RTL
  • i2c_host_perf has a bizarre calculation for speed that gets affected by stretching that randomly occurs
  • i2c_target_unexp_stop appears to not generate correct stimulus
  • i2c_target_perf generates incorrect stimulus, with SDA and SCL switching simultaneously
  • i2c_target_stretch I haven't looked at

@hcallahan-lowrisc
Copy link
Contributor

hcallahan-lowrisc commented May 13, 2024

Moving tracked effort from this issue to #23077
(This issue can stay open for now, but should be closed when that issue is closed)

@moidx
Copy link
Contributor

moidx commented Jun 11, 2024

Discussed moving as P1 to M5 due to RTL risk analysis performed during last issue triage.

@hcallahan-lowrisc
Copy link
Contributor

This PR doesn't really accurately represent the state of the I2C regressions anymore. Hence I'm going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV DV issue: testbench, test case, etc. IP:i2c
Projects
None yet
Development

No branches or pull requests

5 participants