Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rv_plic,dv] Implement assertions EdgeTriggeredIp_A and EdgeTriggeredIpWithClaim_A #17412

Closed
andreaskurth opened this issue Mar 1, 2023 · 3 comments · Fixed by #21655
Closed

[rv_plic,dv] Implement assertions EdgeTriggeredIp_A and EdgeTriggeredIpWithClaim_A #17412

andreaskurth opened this issue Mar 1, 2023 · 3 comments · Fixed by #21655
Assignees
@msfschaffner
Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:rv_plic Priority:P2 Priority: medium
Milestone
Earlgrey-PROD.M5

Comments

@andreaskurth
Copy link
Contributor

andreaskurth commented Mar 1, 2023 •
edited
Loading

Those two assertions are defined in rv_plic_fpv_testplan.hjson.tpl, but they are not implemented.

2
@andreaskurth andreaskurth added Component:DV DV issue: testbench, test case, etc. Priority:P2 Priority: medium IP:rv_plic Triaged labels Mar 1, 2023
@andreaskurth andreaskurth added this to the Discrete: M2.5 milestone Mar 1, 2023
@johngt
Copy link

johngt commented Apr 19, 2023

Assigning currently to @msfschaffner to decide who to forward assign to.

@msfschaffner
Copy link
Contributor

I don't think this is critical right now, since we already test the PLIC quite extensively at the system level. I think we can defer this .
CC @cindychip @moidx

@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 7, 2023
This was referenced Feb 23, 2024
Closed
Closed
@msfschaffner
Copy link
Contributor

Turns out that these assertions should have been removed from the testplan when we removed the option for interrupts to use edge triggered signalling.

msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Feb 23, 2024
@msfschaffner
[rv_plic/fpv] Remove stale testplan entries
103b01a 
These two assertions tested edge triggered interrupts, but since
the option of edge signalling has been removed a long time ago, these
two testplan entries are stale and can be removed.

Fixes lowRISC#17412

Signed-off-by: Michael Schaffner <[email protected]>
@msfschaffner msfschaffner mentioned this issue Feb 23, 2024
Merged
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Feb 26, 2024
@msfschaffner
[rv_plic/fpv] Remove stale testplan entries
65ad8b5 
These two assertions tested edge triggered interrupts, but since
the option of edge signalling has been removed a long time ago, these
two testplan entries are stale and can be removed.

Fixes lowRISC#17412

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit that referenced this issue Feb 26, 2024
@msfschaffner
[rv_plic/fpv] Remove stale testplan entries
d0d38b7 
These two assertions tested edge triggered interrupts, but since
the option of edge signalling has been removed a long time ago, these
two testplan entries are stale and can be removed.

Fixes #17412

Signed-off-by: Michael Schaffner <[email protected]>
BasitMehmood pushed a commit to BasitMehmood/opentitan that referenced this issue Feb 27, 2024
@msfschaffner @BasitMehmood
[rv_plic/fpv] Remove stale testplan entries
3436dd5 
These two assertions tested edge triggered interrupts, but since
the option of edge signalling has been removed a long time ago, these
two testplan entries are stale and can be removed.

Fixes lowRISC#17412

Signed-off-by: Michael Schaffner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msfschaffner msfschaffner

Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:rv_plic Priority:P2 Priority: medium
Projects
None yet
Milestone
Earlgrey-PROD.M5
Development

Successfully merging a pull request may close this issue.

[rv_plic/fpv] Remove stale testplan entries msfschaffner/opentitan
3 participants
@johngt @andreaskurth @msfschaffner