Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align CI config; Drop EOL Node.js versions #648

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Align CI config; Drop EOL Node.js versions #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
571dc12
ci: pin GHA Actions
achrinza Oct 26, 2023
3cfa2a1
ci: update Node.js test versions
achrinza Oct 26, 2023
d5d0bd7
chore!: drop support for Node.js < v16
achrinza Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 12 additions & 26 deletions .github/workflows/continuous-integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,44 +19,30 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [10, 12, 14, 16]
node-version: [16, 18, 20, 21]
include:
- os: macos-latest
node-version: 14 # LTS
node-version: 18 # LTS
- os: windows-latest
node-version: 14 # LTS
node-version: 18 # LTS
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # tag=v4.1.1
with:
fetch-depth: 0
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # tag=v4.0.0
with:
node-version: ${{ matrix.node-version }}
- name: Update NPM (Node.js v10)
if: matrix.node-version == 10
run: npm install --global npm@7
- name: Update NPM
if: matrix.node-version != 10
run: npm install --global npm@8
- name: Bootstrap project
if: ${{ matrix.node-version != '8.11.1' }}
run: npm ci --ignore-scripts
- name: Bootstrap project (Node v8.11.1)
if: ${{ matrix.node-version == '8.11.1' }}
run: npm install --ignore-scripts
- name: Build project
run: npm run --ignore-scripts build
- name: Run tests
run: npm test --ignore-scripts
- name: troubleshooting
run: |
ls
ls ./coverage
- name: Coveralls Parallel
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@3dfc5567390f6fa9267c0ee9c251e4c8c3f18949 # tag=v2.2.3
with:
github-token: ${{ secrets.github_token }}
flag-name: run-${{ matrix.os }}-node@${{ matrix.node-version }}
Expand All @@ -69,7 +55,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Coveralls Finish
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@3dfc5567390f6fa9267c0ee9c251e4c8c3f18949 # tag=v2.2.3
with:
github-token: ${{ secrets.github_token }}
parallel-finished: true
Expand All @@ -79,11 +65,11 @@ jobs:
runs-on: ubuntu-latest
if: ${{ github.event.pull_request }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # tag=v4.1.1
with:
fetch-depth: 0
- name: Use Node.js 16
uses: actions/setup-node@v4
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # tag=v4.0.0
with:
node-version: 16
- name: Bootstrap project
Expand All @@ -98,11 +84,11 @@ jobs:
# See: https://github.com/github/codeql-action/blob/008b2cc71c4cf3401f45919d8eede44a65b4a322/README.md#usage
security-events: write
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # tag=v4.1.1
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@49abf0ba24d0b7953cb586944e918a0b92074c80 # tag=v2.22.4
with:
languages: 'javascript'
config-file: ./.github/codeql/codeql-config.yaml
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@49abf0ba24d0b7953cb586944e918a0b92074c80 # tag=v2.22.4
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "3.5.6",
"description": "A minimal node SOAP client",
"engines": {
"node": ">=8.11.1"
"node": "16 || 18 || 20 || 21"
Copy link
Member Author

@achrinza achrinza Oct 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This more explicit versioning aligns with the strategy we have with LoopBack 4.

Note that for non-LTS versions (i.e. odd-numbered versions), we will drop their support and it won't be considered a breaking change.

},
"dependencies": {
"compress": "^0.99.0",
Expand Down
Loading