Align CI config; Drop EOL Node.js versions #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see: loopbackio/security#27 Signed-off-by: Rifa Achrinza <[email protected]>
see: loopbackio/cicd#27 see: loopbackio/cicd#83 Signed-off-by: Rifa Achrinza <[email protected]>
BREAKING CHANGE: This drops explicit support for EOL Node.js versions Signed-off-by: Rifa Achrinza <[email protected]>
achrinza
force-pushed
the
ci/pin-gh-actions
branch
from
40ca364
to
d5d0bd7
Compare
achrinza
changed the title
achrinza
changed the title
achrinza
commented
Oct 26, 2023
| @@ -3,7 +3,7 @@ | |||
| "version": "3.5.6", | |||
| "description": "A minimal node SOAP client", | |||
| "engines": { | |||
| "node": ">=8.11.1" | |||
| "node": "16 || 18 || 20 || 21" | |||
There was a problem hiding this comment.
This more explicit versioning aligns with the strategy we have with LoopBack 4.
Note that for non-LTS versions (i.e. odd-numbered versions), we will drop their support and it won't be considered a breaking change.
This was referenced Oct 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is considered a breaking change.