Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove passport dependencies #191

Merged
merged 1 commit into from
Jul 4, 2019
Merged

chore: remove passport dependencies #191

merged 1 commit into from
Jul 4, 2019

Conversation

emonddr
Copy link
Contributor

@emonddr emonddr commented Jul 3, 2019 •
edited
Loading

Update to latest @loopback/authentication , so that package-lock.json no longer contains any references to 'passport' packages

Related to: #175

I manually updated the version numbers of @loopback/... packages in package.json files

authentication package depends on context and core, so I updated all @loopback packages to their latest numbers as of July 3, 2019.

I did not manually change package-lock.json files, but they were changed indirectly due to my changes to the package.json files.

I ran npm run build and npm run test and everything passes successfully.

@emonddr emonddr requested review from bajtos and removed request for raymondfeng July 3, 2019 18:15
bajtos
bajtos reviewed Jul 4, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any obvious problems and all CI checks are green. FWIW, LGTM.

@emonddr
Copy link
Contributor Author

emonddr commented Jul 4, 2019

I don't see any obvious problems and all CI checks are green. FWIW, LGTM.

Hi Miroslav, thanks. Please approve. :)

@emonddr emonddr merged commit febfe59 into master Jul 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the dremond_update_authentication_version branch July 4, 2019 13:00
@jannyHou
Copy link
Contributor

jannyHou commented Jul 4, 2019

LGTM 👍

@dhmlau dhmlau mentioned this pull request Aug 1, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@jannyHou jannyHou Awaiting requested review from jannyHou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emonddr @jannyHou @bajtos