Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json and package-lock.json to remove passport references #175

Closed
1 task
emonddr opened this issue Jun 24, 2019 · 5 comments
Closed
1 task
Assignees
Labels
2019Q3 Target for 2019 Q3 Authentication

Comments

@emonddr
Copy link
Contributor

emonddr commented Jun 24, 2019

This application depends on @loopback/authentication package.

Just recently, the passport adapter was moved into its own package : @loopback/authentication-passport .

All references to passport in @loopback/authentication was recently removed in PR
loopbackio/loopback-next#3224 . Once this change is released, then this shopping cart example's package.json and package-lock.json needs to be updated to new version numbers, and needs to remove all 'passport' references.

Related to recent work done for a passport adapter : loopbackio/loopback-next#2311

Acceptance Criteria

  • mocha tests run after package.json and package-lock.json have been cleaned
@emonddr emonddr self-assigned this Jun 24, 2019
@emonddr
Copy link
Contributor Author

emonddr commented Jun 24, 2019

https://github.com/strongloop/loopback4-example-shopping/blob/master/packages/shopping/package-lock.json

...
"@loopback/authentication": {
			"version": "2.1.2",
			"resolved": "https://registry.npmjs.org/@loopback/authentication/-/authentication-2.1.2.tgz",
			"integrity": "sha512-qvUtSCgX8aWyybdRCoQyo27Yk682yTTJq2MZrGp4kMXG6yPx2weY4ONmKcWkGmUH7EhzEyQhiR6d9Lvnwj8KGw==",
			"requires": {
				...
				"passport": "^0.4.0",
				"passport-strategy": "^1.0.0"
                                 ...
			}
		},
...

@emonddr
Copy link
Contributor Author

emonddr commented Jun 24, 2019

In https://github.com/strongloop/loopback4-example-shopping/blob/master/packages/shopping/package.json

we need to remove

 "dependencies": {
...
    "@types/passport": "1.0.0",
...
  },

@dhmlau dhmlau added the 2019Q3 Target for 2019 Q3 label Jun 25, 2019
@dhmlau
Copy link
Member

dhmlau commented Jun 25, 2019

Putting the estimate as 1 because the effort is small and it's more time consuming to go through the estimation process. :)

@dhmlau
Copy link
Member

dhmlau commented Aug 1, 2019

@emonddr, is this done? I saw the PR #191 has merged. Thanks.

@emonddr emonddr closed this as completed Aug 1, 2019
@emonddr
Copy link
Contributor Author

emonddr commented Aug 1, 2019

@emonddr, is this done? I saw the PR #191 has merged. Thanks.

yes it is done. thx. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2019Q3 Target for 2019 Q3 Authentication
Projects
None yet
Development

No branches or pull requests

3 participants