Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Connector docs to LB4 docs #863

Merged
merged 1 commit into from
Jul 31, 2019
Merged

feat: add Connector docs to LB4 docs #863

merged 1 commit into from
Jul 31, 2019

Conversation

hacksparrow
Copy link
Contributor

Add Connector docs to LB4 docs.

Required to fix loopbackio/loopback-next#2598.

@hacksparrow hacksparrow requested a review from bschrammIBM as a code owner July 31, 2019 14:07
@hacksparrow hacksparrow mentioned this pull request Jul 31, 2019
Closed
5 tasks
dhmlau
dhmlau reviewed Jul 31, 2019
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@hacksparrow hacksparrow force-pushed the feat/lb4-connector-docs branch from d53b9fb to 2f7de96 Compare July 31, 2019 15:32
@raymondfeng raymondfeng mentioned this pull request Jul 31, 2019
Merged
b-admike
b-admike reviewed Jul 31, 2019
View reviewed changes
Copy link
Contributor

@b-admike b-admike left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Do we need to copy the files in update-readmes.sh again though since we are doing it in the update-lb4-docs.js script?

@raymondfeng
Copy link
Contributor

@hacksparrow Please fix the CI issue - https://travis-ci.org/strongloop/loopback.io/builds/566037056?utm_source=github_status&utm_medium=notification

@hacksparrow
Copy link
Contributor Author

@b-admike

Nice. Do we need to copy the files in update-readmes.sh again though since we are doing it in the update-lb4-docs.js script?

They are working on different set of files:

  • update-readmes.sh -> README files specifically from external repos
  • update-lb4-docs.js -> Doc files which already exists in the lb3 dir

@hacksparrow hacksparrow force-pushed the feat/lb4-connector-docs branch from 2f7de96 to 92e179a Compare July 31, 2019 15:53
jannyHou
jannyHou approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

update-readmes.sh
@@ -8,6 +8,7 @@
# from the given github repo. If that branch is NOT master, then the
# branch name will be appended to the local readme file name.
(cat <<LIST_END
strongloop loopback-connector-mysql master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: strongloop loopback-connector-couchdb2 master is also supported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add it after this one lands.

feat: add Connector docs to LB4 docs
2c7e2ac 
Add Connector docs to LB4 docs
@hacksparrow hacksparrow force-pushed the feat/lb4-connector-docs branch from 92e179a to 2c7e2ac Compare July 31, 2019 16:04
@hacksparrow hacksparrow merged commit 2c7e2ac into gh-pages Jul 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/lb4-connector-docs branch July 31, 2019 16:13
@hacksparrow hacksparrow temporarily deployed to github-pages July 31, 2019 16:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau dhmlau left review comments

@b-admike b-admike b-admike left review comments

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@jannyHou jannyHou jannyHou approved these changes

@raymondfeng raymondfeng raymondfeng approved these changes

@bschrammIBM bschrammIBM Awaiting requested review from bschrammIBM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Connectors Reference" docs pages to LB4 docs
6 participants
@hacksparrow @raymondfeng @jannyHou @b-admike @dhmlau @nabdelgadir