Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Connector docs to LB4 docs #3481

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Conversation

hacksparrow
Copy link
Contributor

Add Connector docs to LB4 docs.

Required to fix #2598.

@@ -415,6 +414,194 @@ children:
url: Download-examples.html
output: 'web, pdf'

- title: 'Connectors reference'
url: Connectors-reference.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://loopback.io/doc/en/lb4/Connectors-reference.html does not exist. Am I missing something here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many more "external" files, all of which are present in the lb3 dir or made available there eventually. Those files are copied over to the lb4 dir by the build process in loopback.io.

Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Great effort

docs/site/sidebars/lb4_sidebar.yml Outdated Show resolved Hide resolved
docs/site/sidebars/lb4_sidebar.yml Show resolved Hide resolved
@hacksparrow hacksparrow force-pushed the docs/lb4-connectors branch from 4182c13 to 349cb76 Compare July 31, 2019 16:11
Add Connector docs to LB4 docs
@hacksparrow hacksparrow force-pushed the docs/lb4-connectors branch from 349cb76 to 2d7066c Compare July 31, 2019 16:16
@hacksparrow hacksparrow merged commit 2d7066c into master Jul 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the docs/lb4-connectors branch July 31, 2019 16:39
@hacksparrow hacksparrow mentioned this pull request Aug 16, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Connectors Reference" docs pages to LB4 docs
6 participants