Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): update templates to remove Node 6 remnants #998

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

virkt25
Copy link
Contributor

@virkt25 virkt25 commented Feb 15, 2018

Follow up from #996 and related to dropping Node 6 support. CLI template had references to dist6 folders which are no longer generated.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Related API Documentation was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in packages/example-* were updated

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Follow up from #996 and related to dropping Node 6 support. CLI template had references to `dist6` folders which are no longer generated.
@virkt25 virkt25 force-pushed the update-cli-template branch from 0be9f2a to c4b6093 Compare February 15, 2018 16:33
@virkt25 virkt25 merged commit 69bd4f7 into master Feb 15, 2018
@virkt25 virkt25 deleted the update-cli-template branch February 15, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants