-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): switch .template to .ejs #996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to judge the impact of the changes project-generator.js
, but I don't see any obvious problem.
FWIW, LGTM.
Please get somebody more familiar with our CLI package to approve your changes too.
@@ -1,4 +1,3 @@ | |||
dist | |||
dist6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a fan of making unrelated changes. Can you at least split the removal of dist6
entries into a standalone commit please?
@@ -62,5 +62,3 @@ api-docs/ | |||
|
|||
# Transpiled JavaScript files from Typescript | |||
dist/ | |||
dist6/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
Follow up from #996 and related to dropping Node 6 support. CLI template had references to `dist6` folders which are no longer generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@virkt25 there is no test need to upgrade? like compare file name. I am not quite familiar with the cli package, may not be a valid concern, feel free to ignore if tests are good :-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same concern as Janny, otherwise LGTM.
Current tests assert that most of the files that have been renamed exist in a generated project (with actual name not with |
Follow up from #996 and related to dropping Node 6 support. CLI template had references to `dist6` folders which are no longer generated.
Follow up from #996 and related to dropping Node 6 support. CLI template had references to `dist6` folders which are no longer generated.
Switch
.template
to.ejs
for CLI template files. Gives us syntax highlighting instead of error in VSCode.Follow up from #991
Checklist
npm test
passes on your machinepackages/cli
were updatedpackages/example-*
were updated