-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authentication-jwt) Add signup / create user #5763
Conversation
Related to: #5602 |
extensions/authentication-jwt/src/__tests__/fixtures/controllers/user.controller.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready. 👍
extensions/authentication-jwt/src/__tests__/fixtures/controllers/user.controller.ts
Outdated
Show resolved
Hide resolved
extensions/authentication-jwt/src/__tests__/fixtures/controllers/user.controller.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thank you. One more approval and hopefully it will land. 👍
@HrithikMittal, thanks for the PR. Could you please take a look at the code linter and commit linter issue? Thanks! |
@jannyHou, assigning this to you for the additional approval. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HrithikMittal A minor comment to fix the import, otherwise LGTM :)
(sorry didn't realize you created a new PR)
extensions/authentication-jwt/src/__tests__/fixtures/controllers/user.controller.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HrithikMittal The code part is good enough 👍
Almost there, could you follow the instructions that Diana posted in comment #5763 (comment) to fix the lint and commit message? And please squash all commits into one :) Thanks!
Fix lint: npm run lint:fix
Fix the commit message: git rebase -i master
to squash and rename the 1st commit to be
feat(authentication-jwt): add sign up for controller fixture
Hi @HrithikMittal any update on this PR? :) almost ready to land |
Please if you can clean it. Please do it. |
🎉 @HrithikMittal thank you! merged. |
This pull request is to provide the signup method in the authentication-jwt So it would be easier for developers.
https://github.com/strongloop/loopback-next/blob/master/extensions/authentication-jwt/src/__tests__/fixtures/controllers/user.controller.ts
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈