Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authentication-jwt) Add signup / create user #5763

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

HrithikMittal
Copy link
Contributor

This pull request is to provide the signup method in the authentication-jwt So it would be easier for developers.
https://github.com/strongloop/loopback-next/blob/master/extensions/authentication-jwt/src/__tests__/fixtures/controllers/user.controller.ts

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dhmlau
Copy link
Member

dhmlau commented Jun 17, 2020

Related to: #5602

@dougal83 dougal83 changed the title This is the Branch to resolve all the errors in https://github.com/strongloop/loopback-next/pull/5602 feat(authentication-jwt) Add signup / create user Jun 18, 2020
Copy link
Contributor

@dougal83 dougal83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready. 👍

Copy link
Contributor

@dougal83 dougal83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you. One more approval and hopefully it will land. 👍

@dhmlau
Copy link
Member

dhmlau commented Jun 22, 2020

@HrithikMittal, thanks for the PR. Could you please take a look at the code linter and commit linter issue?
For code linter, you can run npm run lint:fix to fix it.
For commit linter, please refer to https://loopback.io/doc/en/lb4/code-contrib-lb4.html#commit-message-guidelines. I'd suggest to add the feat(authentication-jwt) prefix to the commit message.

Thanks!

@dhmlau
Copy link
Member

dhmlau commented Jun 22, 2020

@jannyHou, assigning this to you for the additional approval. Thanks.

Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HrithikMittal A minor comment to fix the import, otherwise LGTM :)
(sorry didn't realize you created a new PR)

Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HrithikMittal The code part is good enough 👍

Almost there, could you follow the instructions that Diana posted in comment #5763 (comment) to fix the lint and commit message? And please squash all commits into one :) Thanks!

Fix lint: npm run lint:fix
Fix the commit message: git rebase -i master to squash and rename the 1st commit to be
feat(authentication-jwt): add sign up for controller fixture

@jannyHou
Copy link
Contributor

Hi @HrithikMittal any update on this PR? :) almost ready to land

@HrithikMittal
Copy link
Contributor Author

Hi @HrithikMittal any update on this PR? :) almost ready to land

Please if you can clean it. Please do it.

@jannyHou jannyHou merged commit d481157 into loopbackio:master Jul 24, 2020
@jannyHou
Copy link
Contributor

🎉 @HrithikMittal thank you! merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants