Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "signup" / create user in authentication-jwt module #5312

Closed
1 task
dhmlau opened this issue May 2, 2020 · 3 comments
Closed
1 task

Add "signup" / create user in authentication-jwt module #5312

dhmlau opened this issue May 2, 2020 · 3 comments

Comments

@dhmlau
Copy link
Member

dhmlau commented May 2, 2020

Suggestion

In the authentication-jwt extension, the user experience would be much nicer if it includes the default implementation for creating user as well.

I'm trying to use this extension in my app, and I'd also want to have the "signup" REST API. In order to do that, I need to (I'm still in the middle of it, so the list may not be complete):

  • add the signup endpoint in the UserController

cc @jannyHou @raymondfeng

Acceptance criteria

@jannyHou
Copy link
Contributor

jannyHou commented May 7, 2020

@dhmlau Agreed 👍

@dhmlau
Copy link
Member Author

dhmlau commented May 7, 2020

For your reference, i've added the signup endpoint in my repo: https://github.com/dhmlau/loopback4-example-todo-jwt/.

@dhmlau
Copy link
Member Author

dhmlau commented Jul 27, 2020

Resolved via #5763. Closing as done.

@dhmlau dhmlau closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants