Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] feat(docs): May milestone #5189

Closed
wants to merge 2 commits into from
Closed

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Apr 21, 2020

Overview:

  • finish migration guide - depending on the tasks created from the spikes
  • docs and bug fixes

There are 28 points for the Goals.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM 👍

docs/_may_milestone_.md Outdated Show resolved Hide resolved
- [ ] How to build models, repositories and controllers dynamically at runtime
#4296
- [ ] Spike: robust handling of ObjectID type for MongoDB #3456
- [ ] Integration with TypeORM #4853
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm #4853 doesn't seem like a miscellaneous task 🤔 maybe move it under feature party?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Miscellaneous" is just a category to put anything doesn't fit in docs and bugs at this moment. if we have more integration work related, i can create a "integration" section.

docs/_may_milestone_.md Outdated Show resolved Hide resolved
- [ ] PRs to review
- [ ] feat(repository): hasManyThrough #4438
- [ ] [RFC] Enable parallel mocha testing #5011
- [ ] feat(http-server): adds http/2 support #4989
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raymondfeng can you please add 2-3 of your pull requests you would like the team to focus on reviewing during May?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also like to get this refresh token PR reviewed: loopbackio/loopback4-example-shopping#537

Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhmlau
Copy link
Member Author

dhmlau commented May 1, 2020

Closing this as #5301 is opened. Thanks @jannyHou!

@dhmlau dhmlau closed this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants