Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with TypeORM #4853

Closed
3 tasks
dhmlau opened this issue Mar 10, 2020 · 14 comments
Closed
3 tasks

Integration with TypeORM #4853

dhmlau opened this issue Mar 10, 2020 · 14 comments

Comments

@dhmlau
Copy link
Member

dhmlau commented Mar 10, 2020

By default, LoopBack juggler is used. LoopBack also has the flexibility to integrate other ORMs, like TypeORM. There is an existing PR #4794

Acceptance Criteria

@mschnee
Copy link
Contributor

mschnee commented Mar 26, 2020

This is awesome. I know a lot of people use Mongoose, and TypeORM; the user story that you can bring your current ORM/ODM experience to your loopback application is a powerful one.

How do we feel about having a more concrete example, than provided in the acceptance tests? For example, the most basic loopback application possible, built to showcase using TypeORM (in this case)? I'm not saying every single feature typeorm provides needs to be highlighted, but just enough of a basic structure (some models, maybe a couple of different connections to different databases).

And is the PR a good place for discussion, or is this issue more appropriate?

@dhmlau
Copy link
Member Author

dhmlau commented Mar 27, 2020

I think an example would be great. Do you mean to use the TypeORM component in #4794 and create an example on how to use it?

@dhmlau
Copy link
Member Author

dhmlau commented Mar 27, 2020

cc @raymondfeng

@raj-298585
Copy link

Probably with complete endpoint example from controller, model, repository including on how to create openapi schemas using decorators. I have tries this example, only place I struggled was to frame openapi schemas for "filters" using decorators with typeorm.

@raymondfeng
Copy link
Contributor

@raj-298585 Thank you for chiming in - we have some prior efforts to transform LB repository apis into TypeORM implementation - see #763.

I'll spend some time to build an e2e acceptance test and go from there.

@pookdeveloper
Copy link

I need that, actually I use TypeORM in Lb3 :)

@sbacem
Copy link

sbacem commented Jun 10, 2020

Good i need this also 👍,
It would be compatible with loopback Cli ?

@hacksparrow
Copy link
Contributor

It would be compatible with loopback Cli ?

You mean lb4? With the relevant packages updated the app should continue to work as usual.

@sbacem
Copy link

sbacem commented Jun 10, 2020

I mean
we can create with the loopback generator cli a Controller, Entity, Repository which works with TypeOrm

@hacksparrow
Copy link
Contributor

Yep.

@sbacem
Copy link

sbacem commented Jun 12, 2020

We are impatiently awaiting this development,
Sometimes we were forced to make native SQL requests in our platform http://ioc.tn/ 😞
Thank you for this pleasant Framework, 👍 👍
We contain to recommend this Framework for our customers to https://iotech.tn/

@hacksparrow
Copy link
Contributor

Targeting for landing some time coming week, no promises though.

@hacksparrow
Copy link
Contributor

@sbacem here's the WIP PR - #5801. Any feedback?

@dhmlau dhmlau modified the milestones: Jun 2020, Jul 2020 Jun 30, 2020
@dhmlau dhmlau added Slipped and removed 2020Q2 labels Jun 30, 2020
@agnes512
Copy link
Contributor

Closing as done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants