Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC WIP] feat(typeorm): add a component for TypeORM integration #4794

Closed
wants to merge 1 commit into from

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Mar 4, 2020

A PoC to illustrate possible shadow integration with TypeORM:

  • TypeOrmComponent to maintain connections
  • @typeorm.connection to provide injection of TypeORM connections - can be extended to allow repository...

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@raymondfeng raymondfeng changed the title [RFC WIP] feat(typeorm): add a compoennt for TypeORM integration [RFC WIP] feat(typeorm): add a compoent for TypeORM integration Mar 9, 2020
@raymondfeng raymondfeng changed the title [RFC WIP] feat(typeorm): add a compoent for TypeORM integration [RFC WIP] feat(typeorm): add a component for TypeORM integration Mar 9, 2020
@raymondfeng raymondfeng force-pushed the typeorm branch 2 times, most recently from fe0c012 to 9cd6f79 Compare March 9, 2020 20:36
@dhmlau dhmlau mentioned this pull request Mar 10, 2020
3 tasks
@raymondfeng raymondfeng marked this pull request as ready for review March 27, 2020 17:25
@raymondfeng raymondfeng requested a review from bajtos as a code owner March 27, 2020 17:25
@raymondfeng
Copy link
Contributor Author

Some prior effort - #763

@bajtos
Copy link
Member

bajtos commented Jun 26, 2020

@raymondfeng @hacksparrow Can we close this in favor of #5801 now?

@hacksparrow
Copy link
Contributor

We can close it, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants