Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up tests for "lb4 relation" command #3748

Merged
merged 6 commits into from
Sep 17, 2019
Merged

Clean up tests for "lb4 relation" command #3748

merged 6 commits into from
Sep 17, 2019

Commits on Sep 16, 2019

  1. test(cli): refactor "fixtures/relation" to reduce code duplication 

    Signed-off-by: Miroslav Bajtoš <[email protected]>
    @bajtos
    bajtos committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    3b8bd79 View commit details
    Browse the repository at this point in the history

  2. test(cli): clean up relation tests 

    - rename files to follow the pattern `relation.{type}.integration.ts`
- move relation-type-specific tests from `relation.integration.ts`
  to relation-type-specific test files

Signed-off-by: Miroslav Bajtoš <[email protected]>
    @bajtos
    bajtos committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    9446e84 View commit details
    Browse the repository at this point in the history

  3. test(cli): improve readability of tests by inlining SANDBOX_FILES{n} 

    Replace variables like `SANDBOX_FILES6` with an array of source files
to copy. This makes the tests easier to read. The name `SANDBOX_FILES6`
does not say anything about the files in the array, while a list
of files like `CustomerModelWithOrdersProperty` makes the intent clear.

Signed-off-by: Miroslav Bajtoš <[email protected]>
    @bajtos
    bajtos committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    78ec99d View commit details
    Browse the repository at this point in the history

  4. test(cli): improve structure of relation.has-many.integration.js 

    Signed-off-by: Miroslav Bajtoš <[email protected]>
    @bajtos
    bajtos committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    a417e8c View commit details
    Browse the repository at this point in the history

  5. test(cli): improve structure of relation.belongs-to.integration.js 

    Signed-off-by: Miroslav Bajtoš <[email protected]>
    @bajtos
    bajtos committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    053224a View commit details
    Browse the repository at this point in the history

  6. test(cli): fix incorrect callback usage 

    Signed-off-by: Miroslav Bajtoš <[email protected]>
    @bajtos
    bajtos committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    f8138d5 View commit details
    Browse the repository at this point in the history