Clean up tests for "lb4 relation" command #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Bajtoš <[email protected]>
- rename files to follow the pattern `relation.{type}.integration.ts`
- move relation-type-specific tests from `relation.integration.ts`
to relation-type-specific test files
Signed-off-by: Miroslav Bajtoš <[email protected]>
Replace variables like `SANDBOX_FILES6` with an array of source files to copy. This makes the tests easier to read. The name `SANDBOX_FILES6` does not say anything about the files in the array, while a list of files like `CustomerModelWithOrdersProperty` makes the intent clear. Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
6 tasks
agnes512
approved these changes
Sep 16, 2019
Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
force-pushed
the
refactor/cli-relation-tests
branch
from
4ca8d36
to
f8138d5
Compare
nabdelgadir
approved these changes
Sep 16, 2019
|
|
||
| const sandbox = new TestSandbox(SANDBOX_PATH); | ||
|
|
||
| const hasManyrImportRegEx = /import \{Entity, model, property, hasMany\} from '@loopback\/repository';\n/; |
There was a problem hiding this comment.
what is the r in hasManyrImportRegEx for?
There was a problem hiding this comment.
I think it's probably a typo, this line was copied with no changes.
raymondfeng
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I am significantly cleaning up integration tests for
lb4 relationcommand. It's best to review the changes one commit at a time, I recommend to ignore white-space changes too.List of commits/changes:
relation.{type}.integration.tsrelation.integration.tsto relation-type-specific test filesSANDBOX_FILES{n}relation.has-many.integration.jsandrelation.belongs-to.integration.jsby fixing nesting ofdescribeandcontextblocks and grouping parameterized groups intodescribeblocks with a descriptive titles generated from the parameter valuesThis pull request is a follow-up for #3716 (comment).
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈