Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tsdocs): make it possible to run api-extractor on a package #3113

Merged
merged 1 commit into from
Jun 12, 2019
Merged

feat(tsdocs): make it possible to run api-extractor on a package #3113

merged 1 commit into from
Jun 12, 2019

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Jun 11, 2019 •
edited
Loading

Use packages/tsdocs/bin/extract-apis.js --package-only

See #3039

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@raymondfeng raymondfeng requested a review from bajtos as a code owner June 11, 2019 19:47
@raymondfeng raymondfeng force-pushed the tsdocs-for-pkg branch 2 times, most recently from 614b58e to eff7310 Compare June 11, 2019 22:32
jannyHou
jannyHou approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice LGTM.

@raymondfeng raymondfeng merged commit 6eb5773 into master Jun 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the tsdocs-for-pkg branch June 12, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannyHou jannyHou jannyHou approved these changes

@bajtos bajtos Awaiting requested review from bajtos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raymondfeng @jannyHou