Add test case for operations returning promise #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-admike
reviewed
May 8, 2018
test/test.js
Outdated
|
|
||
| // Short method names | ||
| StockQuoteService.GetQuote({symbol: 'IBM'}).then(function (response) { | ||
| console.log("response: " + response.GetQuoteResult); |
shimks
force-pushed
the
add-promise-test-case
branch
from
6073a58 to
b691f7e
Compare
b-admike
approved these changes
May 8, 2018
raymondfeng
approved these changes
May 8, 2018
virkt25
approved these changes
May 8, 2018
shimks
force-pushed
the
add-promise-test-case
branch
from
b691f7e to
517399b
Compare
|
Released as 4.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: the added test case will fail since the endpoint it's testing for is down. Considering that the error is thrown properly with
done, one may say that the test fulfills its intended purpose despite it failing 😅Related issues
Checklist
guide