-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promisification of Juggler DAO methods for service integration #1272
Promisification of Juggler DAO methods for service integration #1272
Comments
We need to check the following connectors: |
A bit of additional context. In theory, I see two possible approaches:
Since a half of our connectors already support promises, adding promise support at connector level is pretty easy and promisification at DataSource level is tricky, I personally prefer the first approach - adding promise support in individual connectors. I am proposing the following acceptance criteria:
For completeness, there is a fifth service-like connector loopback-connector-remote and it already supports promises ✅ |
I've added support for promises in One problem with adding the test case for said package is that the tests are failing on |
Description
As part of weakly typed service integration for REST/SOAP and other services, LoopBack 3 connectors should have support for promises. This would let us use async/await. We'd like to change this.
Related to #1069
Acceptance Criteria
see https://github.com/strongloop/strong-soap/blob/master/src/client.js
see https://github.com/strongloop/loopback-connector-grpc/blob/master/lib/grpc-connector.js#L108
The text was updated successfully, but these errors were encountered: