-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run shared tests from both v3 and v4 of juggler #376
Conversation
Please note the test failures are coming from juggler v4, we haven't been running those tests yet. I'll fix them before landing this PR if we decide to continue in this direction. |
Should be fixed now, via loopbackio/loopback-datasource-juggler#1733 and |
This test sometimes passes and other times it fails and the error message is not clear about what went wrong :(
The CI re-runs the tests with DEBUG logs enabled and then the test suite passes. I am proposing to ignore this problem for now. Node.js 6 has reached EOL few days ago, I think it's time to remove it from our CI platforms.
I suspect this is intermittent too, I've seen this error few times on my machine too, but not always.
|
@slnode test please |
All checks have passed this time. This pull request is ready for final review & landing. (I'll clean up the git history before merging.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, hopefully we can see the changes in action soon.
f0d671f
to
d8882c2
Compare
At the moment, our connectors are installing juggler 3.x to run the test suite. When we make a change to juggler@3, cis-jenkins detects downstream dependency and triggers CI build of connectors with the modified juggler version. When we make a change to juggler's master, no downstream builds are triggered.
In the past, we were maintaining multiple branches to test connectors against different juggler versions. E.g.
loopback-2.x
containing code from "master" but installing juggler 2.x for testing. This is rather impractical, because we don't have bandwidth to update those other branches with changes made to master.In this pull request, I am reworking connector test setup to execute tests from both juggler versions 3.x and 4.x.
Checklist
guide