Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run shared tests from both v3 and v4 of juggler #79

Closed
bajtos opened this issue May 20, 2019 · 3 comments
Closed

Run shared tests from both v3 and v4 of juggler #79

bajtos opened this issue May 20, 2019 · 3 comments
Assignees
Milestone

Comments

@bajtos
Copy link
Member

bajtos commented May 20, 2019

At the moment, our connectors are installing juggler 3.x to run the test suite. When we make a change to juggler@3, cis-jenkins detects downstream dependency and triggers CI build of connectors with the modified juggler version. When we make a change to juggler's master, no downstream builds are triggered.

In the past, we were maintaining multiple branches to test connectors against different juggler versions. E.g. loopback-2.x containing code from "master" but installing juggler 2.x for testing. This is rather impractical, because we don't have bandwidth to update those other branches with changes made to master.

Let's rework the connector test setup to execute tests from both juggler versions 3.x and 4.x, as we are already doing in other connector repositories.

The reference pull request to draw inspiration from: loopbackio/loopback-connector-mongodb#519. See also loopbackio/loopback-connector-postgresql#376.

Before making these changes, we first need to fix the current test suite to pass, see #76

@stale
Copy link

stale bot commented Oct 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 14, 2019
@dhmlau dhmlau removed the stale label Oct 23, 2019
@dhmlau dhmlau added 2020Q1 and removed 2019Q4 labels Nov 15, 2019
@stale
Copy link

stale bot commented Jan 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@agnes512
Copy link
Contributor

closing as done!

@dhmlau dhmlau added this to the Feb 2020 milestone Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants