Support ruleset-defined custom actions in client #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoureaux
reviewed
Mar 8, 2022
There was a problem hiding this comment.
Added to game.ruleset in classic:
; Blank ruleset defined user actions.
; See the section "Ruleset defined actions" is doc/README.actions
; Example: set up "User Action 1"
ui_name_user_action_1 = _("%sDisrupt Supply Lines%s")
user_action_1_target_kind = "tiles"
user_action_1_min_range = 1
user_action_1_max_range = 3
user_action_1_actor_consuming_always = FALSE
[actionenabler_user_1]
action = "User Action 1"-> it works.
Some functions are crying for a docstring and I don't want them to feel lonely in the code. Since this is C++, user_action_N could have been a template but it's fine as it is.
User Action 1 through 3 may be defined by the ruleset, allow ordering them through the action selection dialog. Action Target Kind depends on the ruleset, so dispatch on it at runtime to determine the semantics of qv2. Closes longturn#936.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Action 1 through 3 may be defined by the ruleset, allow ordering
them through the action selection dialog.
Action Target Kind depends on the ruleset, so dispatch on it at
runtime to determine the semantics of qv2.
Closes #936.