Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt client does not support User Actions #936

Closed
ec429 opened this issue Mar 6, 2022 · 0 comments · Fixed by #937
Closed

Qt client does not support User Actions #936

ec429 opened this issue Mar 6, 2022 · 0 comments · Fixed by #937
Labels
bug Something isn't working Untriaged This issue or PR needs triaging

Comments

@ec429
Copy link
Contributor

ec429 commented Mar 6, 2022

Describe the bug
The three ruleset-defined actions (User Action 1-3) can't be performed from the action selection dialog.

To Reproduce
Steps to reproduce the behavior:

  1. Load a ruleset with a User Action
  2. Attempt to perform the action with a unit that should be able to do it
  3. Action does not appear in the dialog and cannot be ordered.

Expected behavior
Action and its probability should appear in the dialog, like any other action.

Additional context
Needs handlers adding to the af_map in client/gui-qt/dialogs.cpp.
@ec429 ec429 added bug Something isn't working Untriaged This issue or PR needs triaging labels Mar 6, 2022
ec429 added a commit to ec429/freeciv21 that referenced this issue Mar 6, 2022
@ec429
Support ruleset-defined custom actions in client
b5c2947 
User Action 1 through 3 may be defined by the ruleset, allow ordering
 them through the action selection dialog.
Action Target Kind depends on the ruleset, so dispatch on it at
 runtime to determine the semantics of qv2.

Closes longturn#936.
ec429 added a commit to ec429/freeciv21 that referenced this issue Mar 6, 2022
@ec429
Support ruleset-defined custom actions in client
0ec5d25 
User Action 1 through 3 may be defined by the ruleset, allow ordering
 them through the action selection dialog.
Action Target Kind depends on the ruleset, so dispatch on it at
 runtime to determine the semantics of qv2.

Closes longturn#936.
@ec429 ec429 mentioned this issue Mar 6, 2022
Merged
ec429 added a commit to ec429/freeciv21 that referenced this issue Mar 18, 2022
@ec429
Support ruleset-defined custom actions in client
23ab0b9 
User Action 1 through 3 may be defined by the ruleset, allow ordering
 them through the action selection dialog.
Action Target Kind depends on the ruleset, so dispatch on it at
 runtime to determine the semantics of qv2.

Closes longturn#936.
lmoureaux pushed a commit that referenced this issue Mar 18, 2022
@ec429 @lmoureaux
Support ruleset-defined custom actions in client
a0c3dcc 
User Action 1 through 3 may be defined by the ruleset, allow ordering
 them through the action selection dialog.
Action Target Kind depends on the ruleset, so dispatch on it at
 runtime to determine the semantics of qv2.

Closes #936.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Untriaged This issue or PR needs triaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support ruleset-defined custom actions in client ec429/freeciv21
1 participant
@ec429