Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local sockets #888

Merged
merged 7 commits into from
Feb 15, 2022
Merged

Local sockets #888

merged 7 commits into from
Feb 15, 2022

Conversation

lmoureaux
Copy link
Contributor

@lmoureaux lmoureaux commented Feb 10, 2022 •
edited
Loading

This PR does two things:

  • Fix the --bind server parameter
  • Implement local sockets and use them to communicate with the server spawned by the client for local games

Code is a bit ugly because Qt doesn't leverage OO programming enough in its QIODevice hierarchy.

@lmoureaux lmoureaux force-pushed the bugfix/local-bind branch 2 times, most recently from f9637af to 4a6b97c Compare February 12, 2022 19:13
@lmoureaux lmoureaux marked this pull request as ready for review February 12, 2022 19:18
@lmoureaux lmoureaux requested a review from zekoz February 12, 2022 19:19
@lmoureaux lmoureaux mentioned this pull request Feb 13, 2022
Merged
zekoz
zekoz reviewed Feb 14, 2022
View reviewed changes
server/sernet.h Outdated Show resolved Hide resolved
@lmoureaux lmoureaux mentioned this pull request Feb 14, 2022
Merged
@lmoureaux
Restore --bind <address> functionality
d454a9e 
This allows to bind the server to a specific address, which is often safer.
Support for this option was broken when porting to Qt sockets.
@lmoureaux
Add a --local server option to bind to local socket
3cfdb99 
Local sockets won't trigger any firewall rules.
@lmoureaux
Allow the server to communicate through a local socket
d9c82ab 
Local sockets correspond to UNIX domain sockets on UNIX and named pipes on
Windows.  No networking operations are attempted in this case (not event the
UDP announcements), and the server is strictly restricted to serving the
socket.
@lmoureaux
Add local socket support to the client
97bd62c 
This support is a bit hidden, it is enabled by using the fc21+local URL scheme.
@lmoureaux
Use local sockets for client-spawned servers
83e39cb 
This looks much less suspicious to the Windows firewall.
@lmoureaux
Expand optional_socket_server -> std::optional<socket_server>
8bf6522 
As commented in longturn#888, it didn't improve readability -- rather the opposite.
@lmoureaux
Clarify a comment
99cc076
@lmoureaux lmoureaux enabled auto-merge (rebase) February 15, 2022 00:10
@lmoureaux lmoureaux merged commit 4aca5f7 into longturn:master Feb 15, 2022
@lmoureaux lmoureaux deleted the bugfix/local-bind branch February 15, 2022 00:29
lmoureaux added a commit that referenced this pull request Feb 15, 2022
@lmoureaux
Expand optional_socket_server -> std::optional<socket_server>
c989d63 
As commented in #888, it didn't improve readability -- rather the opposite.
zekoz added a commit to zekoz/freeciv21 that referenced this pull request Feb 17, 2022
@zekoz
Rollback longturn#888
4f408eb
lmoureaux pushed a commit that referenced this pull request Feb 18, 2022
@zekoz @lmoureaux
Rollback #888
3b1c3be
@lmoureaux lmoureaux mentioned this pull request Mar 1, 2022
Merged
@jwrober jwrober mentioned this pull request Mar 5, 2022
Closed
@psampathkumar psampathkumar mentioned this pull request Jun 25, 2022
Closed
@lmoureaux lmoureaux restored the bugfix/local-bind branch December 27, 2023 03:20
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this pull request Dec 27, 2023
@lmoureaux
Expand optional_socket_server -> std::optional<socket_server>
91d97e6 
As commented in longturn#888, it didn't improve readability -- rather the opposite.
@lmoureaux lmoureaux mentioned this pull request Dec 27, 2023
Merged
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this pull request Dec 27, 2023
@lmoureaux
Expand optional_socket_server -> std::optional<socket_server>
1d3a1f0 
As commented in longturn#888, it didn't improve readability -- rather the opposite.
jwrober pushed a commit that referenced this pull request Dec 29, 2023
@lmoureaux @jwrober
Expand optional_socket_server -> std::optional<socket_server>
a376fcf 
As commented in #888, it didn't improve readability -- rather the opposite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekoz zekoz zekoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmoureaux @zekoz