Expand optional_socket_server -> std::optional<socket_server>

As commented in longturn#888, it didn't improve readability -- rather the opposite.
lmoureaux · Dec 27, 2023 · 1d3a1f0 · 1d3a1f0
1 parent e87fda8
commit 1d3a1f0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/server/sernet.cpp b/server/sernet.cpp
@@ -367,7 +367,7 @@ int server_make_connection(QIODevice *new_sock, const QString &client_addr,
    Open server socket to be used to accept client connections
    and open a server socket for server LAN announcements.
  */
-optional_socket_server server_open_socket()
+std::optional<socket_server> server_open_socket()
 {
   // Local socket mode
   if (!srvarg.local_addr.isEmpty()) {

diff --git a/server/sernet.h b/server/sernet.h
@@ -30,9 +30,8 @@ struct connection;
 
 using socket_server =
     std::variant<std::unique_ptr<QTcpServer>, std::unique_ptr<QLocalServer>>;
-using optional_socket_server = std::optional<socket_server>;
 
-optional_socket_server server_open_socket();
+std::optional<socket_server> server_open_socket();
 void flush_packets();
 void incoming_client_packets(connection *pconn);
 void close_connections_and_socket();

diff --git a/server/server.cpp b/server/server.cpp
@@ -129,7 +129,7 @@ void fc_interface_init_server()
 /**
    Server initialization.
  */
-optional_socket_server srv_prepare()
+std::optional<socket_server> srv_prepare()
 {
   // make sure it's initialized
   srv_init();