Pick river/road/rail/maglev sprite depending on terrain class (closes #2232) #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoureaux
requested changes
Mar 31, 2024
There was a problem hiding this comment.
I think we need a new tileset feature flag for this. They're defined at the top of tilespec.cpp:
#define TILESPEC_CAPSTR \
"+Freeciv-tilespec-Devel-2019-Jul-03 duplicates_ok precise-hp-bars " \
"unlimited-unit-select-frames unlimited-upkeep-sprites hex_corner"The documentation page listing them should be updated as well, in docs/Modding/Tileset/compatibility.rst.
lmoureaux
approved these changes
Mar 31, 2024
blabber
reviewed
Mar 31, 2024
| Terrain-specific extra sprites allow for different sprites to be used depending on the terrain. Currently, | ||
| only rivers/roads/rails/maglev sprites may be made terrain-specific, but compatibility for specials and | ||
| bases is expected to roll out soon. To use terrain-specific sprites, use the same nomenclature as before, | ||
| but with the terrain time included after the type of extra. |
There was a problem hiding this comment.
"terrain time" sounds wrong. Should this be "terrain kind" or "terrain tile"?
|
Yep, should be terrain name actually. I can fix that once we tackle the
specials and bases. Unless it needs to be fixed right away?
…On Sun, 31 Mar 2024, 14:42 blabber, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/Modding/Tilesets/compatibility.rst
<#2252 (comment)>:
> @@ -43,3 +43,10 @@ unlimited-upkeep-sprites
hex_corner
Support for this option signals the availability of the new ``hex_corner`` sprite type for terrain.
+
+terrain-specific-extras
+ Terrain-specific extra sprites allow for different sprites to be used depending on the terrain. Currently,
+ only rivers/roads/rails/maglev sprites may be made terrain-specific, but compatibility for specials and
+ bases is expected to roll out soon. To use terrain-specific sprites, use the same nomenclature as before,
+ but with the terrain time included after the type of extra.
"terrain time" sounds wrong. Should this be "terrain kind" or "terrain
tile"?
—
Reply to this email directly, view it on GitHub
<#2252 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJUETHI2RAW27ZMCBUD4NDLY3BKK3AVCNFSM6AAAAABFQQHIX2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZQGM3TMNBSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
A small PR fixing it won't hurt. This way we don't forget |
hugomflavio
added a commit
to hugomflavio/freeciv21
that referenced
this pull request
Mar 31, 2024
jwrober
pushed a commit
that referenced
this pull request
Mar 31, 2024
hugomflavio
added a commit
to hugomflavio/freeciv21
that referenced
this pull request
Apr 3, 2024
Introduced by longturn#2252. Fix is more of a patch than an actual solution. Co-authored-by: Louis Moureaux <[email protected]>
jwrober
pushed a commit
that referenced
this pull request
Apr 3, 2024
Introduced by #2252. Fix is more of a patch than an actual solution. Co-authored-by: Louis Moureaux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.