Colorize (red) negative values on city dialog

[jwrober]

Closes #1511

[jwrober]

CodeFactor found an issue with something I didn't change. Interesting.

[lmoureaux]

CodeFactor found an issue with something I didn't change. Interesting.

You did change the method it's pointing at 😃

I don't think trade, lux, or science can go negative. How much of this code could be factored out in a utility function?

[jwrober]

I don't think trade, lux, or science can go negative. How much of this code could be factored out in a utility function?

If they don't go negative, then why "surplus"?

IDK on the second question. Why the need for another function when in-line IF does the trick?

[lmoureaux]

If they don't go negative, then why "surplus"?

Good question 🤣

IDK on the second question. Why the need for another function when in-line IF does the trick?

To avoid repeating the same code many times (so when we update it we update it everywhere…)

Also: do we need a different color for the classic theme?

[jwrober]

Also: do we need a different color for the classic theme?

The hard code "white" is an issue with Classic. Is there a way to unset a stylesheet?

[jwrober]

I guess I could do a bigger IF with a collection of OR in the evaluation to reduce the number of them.

[lmoureaux]

Where do we have white? I see white-space and red