List small wonders in the client, but hide them by default #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows information that has always been available, but was never shown. Similar to Freeciv osdn#883354. Closes longturn#318.
This effect controls whether information about small wonders is visible to players (and hence sent to the client). It lets one control it for each wonder type separately, or possibly make it depend on the government (it is sadly not possible to make it depend on the diplomatic state). See longturn#318.
|
Figured I'd make some more changes here, hold on |
This sounds like something people may want (see wonders only if you have embassy or something like that), so make it possible to use DiplRel requirements with the Wonder_Visible effect.
|
updated |
jwrober
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client has always known which small wonders any player had built (#318). This adds code to show this in the client. For backward compatibility, the patch also hides small wonders by default, keeping only great wonders. This can be controlled using a new effect
Wonder_Visible. All shipped rulesets use the old way.Closes #318.