Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase MAX_LEN_CAPSTR #1306

Open
lmoureaux opened this issue Aug 22, 2022 · 0 comments
Open

Increase MAX_LEN_CAPSTR #1306

lmoureaux opened this issue Aug 22, 2022 · 0 comments
Labels
changes-network-protocol This issue or PR changes the network protocol enhancement New feature or request

Comments

@lmoureaux
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Freeciv21 uses capabilities quite heavily to implement backward compatibility. As a result, we're already using one fifth of the space allocated for capstrings in the network protocol, which is only 512 bytes.

Describe the solution you'd like

Instead of relying on MAX_LEN_CAPSTR, make the length dynamic in the protocol.

Describe alternatives you've considered

Increasing MAX_LEN_CAPSTR to some larger static value. It means we'll hit the same problem again in the future (unless we start making capabilities mandatory then removing support for old ones)

Additional context

Adding a cap in #1305

@lmoureaux lmoureaux added enhancement New feature or request changes-network-protocol This issue or PR changes the network protocol labels Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-network-protocol This issue or PR changes the network protocol enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant