Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval-pr: provide more instructions for autogame and multiple runs #1226

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Aug 9, 2022

Closes #1220
Closes #1012

@lmoureaux
Copy link
Contributor

#1012 says:

There is also a codeFactor issue around this code block

 if ! [[ -e build_$pull_request ]]; then
   mkdir build_$pull_request
   cd build_$pull_request
   cmake --preset ASan -S ..
   cd ..
 fi

codeFactor wants this to run in a sub-process do loop. It should be fixed at the same time.

I don't think this is fixed in this PR.

@jwrober jwrober requested a review from lmoureaux August 10, 2022 16:52
@jwrober
Copy link
Collaborator Author

jwrober commented Aug 10, 2022

The MacOS failure seems unrelated. Some issue with gettext.

@lmoureaux
Copy link
Contributor

Agreed

Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the ASAN build after a normal build, I get the following:

-- Applying the .diff via patch.

patching file server/unithand.cpp
Reversed (or previously applied) patch detected!  Assume -R? [n] 

scripts/eval-pr Outdated Show resolved Hide resolved
scripts/eval-pr Outdated Show resolved Hide resolved
scripts/eval-pr Show resolved Hide resolved
scripts/eval-pr Outdated Show resolved Hide resolved
@jwrober jwrober enabled auto-merge (rebase) August 10, 2022 22:17
@jwrober jwrober merged commit 13229f5 into longturn:master Aug 10, 2022
@jwrober jwrober deleted the bugfix/eval_pr branch August 10, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants