Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval_pr: break autogame from ASan build to its own command line option #1220

Closed
jwrober opened this issue Aug 8, 2022 · 0 comments · Fixed by #1226
Closed

eval_pr: break autogame from ASan build to its own command line option #1220

jwrober opened this issue Aug 8, 2022 · 0 comments · Fixed by #1226
Assignees
Labels
enhancement New feature or request tools Issues related to mp, ruledit, etc along with CI and build tools.

Comments

@jwrober
Copy link
Collaborator

jwrober commented Aug 8, 2022

Is your feature request related to a problem? Please describe.
Right now the ./scripts/eval_pr script that the admins use to automate the evaluation of pull requests has two compilation methods: Debug and ASan. The Debug method simply compiles, installs and run's cpack and stops. The ASan method compiles with the ASan preset and the automatically runs an autogame.

Describe the solution you'd like
ASan does not compile with Debug, but instead use RelWithDebInfo due to a collection of factors. When running an autogame, it is sometimes useful to run the server and client inside of a debugger (such as gdb) so if an assertion occurs or a segfault of some kind occurs a tester can get a backtrace to aid an issue later on.

What I would like is to have a separate function for calling an autogame in the script. The regular Debug and ASan presets can be used and then if you want the script to run an autogame, you can do that.

Describe alternatives you've considered
Could also simply remove the autostart of the autogame from ASan and simply echo out instructions on how to start one if a user wants to go that route.

Additional context
None

@jwrober jwrober added enhancement New feature or request tools Issues related to mp, ruledit, etc along with CI and build tools. labels Aug 8, 2022
@jwrober jwrober self-assigned this Aug 8, 2022
jwrober added a commit to jwrober/freeciv21 that referenced this issue Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tools Issues related to mp, ruledit, etc along with CI and build tools.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant