Use compile_commands.json with clang-tidy

[lmoureaux]

Otherwise it can't find headers. Also reduce the number of steps using features
of clang-tidy-review.

Hopefully this works...

[psampathkumar]

Set base dir is probably not needed. I added that to try and use the artifacts from Ubuntu build..but doesn't work that way.

[lmoureaux]

Yeah I removed it, but I added build_dir to match what we do elsewhere. I'm not even sure if we support in-source builds 😅

[psampathkumar]

Uh oh. You broke it 😛
And i meant

      - name: Set base_dir
        run: echo "base_dir=$(pwd)" >> $GITHUB_ENV

These aren't needed either.

[psampathkumar]

A nice improvement would be if we can cache clang-tools. Then this would a fast check!

[psampathkumar]

Can you bump version to 0.9.0 ? I think that fixes it.

[psampathkumar]

Still fails :/
psampathkumar#6

[lmoureaux]

clang-tidy failed with return code 1 and error:
Error while trying to load a compilation database:
Could not auto-detect compilation database from directory "build"
No compilation database found in /github/workspace/build or any parent directory
fixed-compilation-database: Error while opening fixed database: No such file or directory
json-compilation-database: Error while opening JSON database: No such file or directory
Running without flags.

then integration bug:

{"message":"Resource not accessible by integration","documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-review-for-a-pull-request"}
Traceback (most recent call last):
  File "/review.py", line 849, in <module>
    main(
  File "/review.py", line 709, in main
    pull_request.post_review(trimmed_review)
  File "/review.py", line 116, in post_review
    post_review_response.raise_for_status()
  File "/usr/local/lib/python3.8/dist-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://api.github.com/repos/pranavtifr/freeciv21/pulls/6/reviews

[psampathkumar]

Ya, I'm just looking at the integration bug.
The integration bug wasnt there yesterday :/

Clang-tidy Idk 🙈

[lmoureaux]

Let's merge this so we get a green check mark at least?